From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CF80AC0218A for ; Thu, 30 Jan 2025 05:14:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6F6EE10E13B; Thu, 30 Jan 2025 05:14:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="Zeq2fGqt"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4837110E13B for ; Thu, 30 Jan 2025 05:14:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738214060; x=1769750060; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=NAqfUKab4uAjJhKUAbQhv4tXo3R10VK/EgGZfSFGC74=; b=Zeq2fGqtuEJtjux/U+mo0exVB/EO27D0ZZR7KS1XpH7ycBRtK/6m/rUq G/caiXakKAvLzYBQ4I3G+bFmhbQy9MjeS+nto8Bh6cWcPQgq16kFErP65 XoFCKF6r4YNmvXMWXWdCYAyaQ041a19VB3gJ+Nua9etWeng3vc9tbQEzV j0m8tWM3MjtPEpCtrGNPRKn/b9utLiJCTkekSSTVJ2jZK4OcpJUK7atQo PWMI0a3Zu9Q8wheAoKlwqagLApn3XluYfDq0+LegOfrUOUsxypamTXzbb DMIeAPw2Ik832gOAeSs8lLl3G5XyL7XzPsY7ho7JtGFOWJm15CRb+RedY w==; X-CSE-ConnectionGUID: jJH13+XpSSicyHjFrUmD1Q== X-CSE-MsgGUID: fu0HfZcgQRymZ4IA6FOVuQ== X-IronPort-AV: E=McAfee;i="6700,10204,11330"; a="50133180" X-IronPort-AV: E=Sophos;i="6.13,244,1732608000"; d="scan'208";a="50133180" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2025 21:14:20 -0800 X-CSE-ConnectionGUID: rHUszgkuQP6Cw+tysS0w1Q== X-CSE-MsgGUID: v/JavG3NTNWkX4HmN7WQZg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="109083438" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jan 2025 21:14:20 -0800 Date: Wed, 29 Jan 2025 21:14:19 -0800 Message-ID: <854j1gg9xw.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: , , , , , , , , Subject: Re: [PATCH v8 7/7] drm/xe/eustall: Add workaround 22016596838 which applies to PVC. In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 15 Jan 2025 12:02:13 -0800, Harish Chegondi wrote: > > Add PVC workaround 22016596838 that disables EU DOP gating > during EU stall sampling. > > Signed-off-by: Harish Chegondi > --- > drivers/gpu/drm/xe/xe_eu_stall.c | 16 ++++++++++++++++ > drivers/gpu/drm/xe/xe_wa_oob.rules | 1 + > 2 files changed, 17 insertions(+) > > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_stall.c > index 6acfd369d808..f030a9c1af84 100644 > --- a/drivers/gpu/drm/xe/xe_eu_stall.c > +++ b/drivers/gpu/drm/xe/xe_eu_stall.c > @@ -13,6 +13,7 @@ > > #include "xe_bo.h" > #include "xe_pm.h" > +#include "xe_wa.h" > #include "xe_trace.h" > #include "xe_macros.h" > #include "xe_device.h" > @@ -26,6 +27,8 @@ > #include "regs/xe_gt_regs.h" > #include "regs/xe_eu_stall_regs.h" > > +#include include in alphabetical order. > + > #define POLL_FREQUENCY_HZ 100 > #define POLL_PERIOD_NS (NSEC_PER_SEC / POLL_FREQUENCY_HZ) > > @@ -677,6 +680,14 @@ xe_eu_stall_stream_enable(struct xe_eu_stall_data_stream *stream) > if (!xe_force_wake_ref_has_domain(fw_ref, XE_FW_RENDER)) > xe_gt_err(gt, "Failed to get RENDER forcewake\n"); > > + /* > + * Wa_22016596838:pvc > + * Disable EU DOP gating for PVC. > + */ Are these comments needed? Other places with XE_WA don't have them? Anyway should be ok. > + if (XE_WA(gt, 22016596838)) > + xe_gt_mcr_multicast_write(gt, ROW_CHICKEN2, > + _MASKED_BIT_ENABLE(DISABLE_DOP_GATING)); > + > reg_value = gen_eustall_base(stream, true); > xe_gt_mcr_multicast_write(gt, XEHPC_EUSTALL_BASE, reg_value); > } > @@ -708,6 +719,11 @@ xe_eu_stall_stream_disable(struct xe_eu_stall_data_stream *stream) > reg_value = gen_eustall_base(stream, false); > xe_gt_mcr_multicast_write(gt, XEHPC_EUSTALL_BASE, reg_value); > > + /* Wa_22016596838:pvc */ > + if (XE_WA(gt, 22016596838)) > + xe_gt_mcr_multicast_write(gt, ROW_CHICKEN2, > + _MASKED_BIT_DISABLE(DISABLE_DOP_GATING)); > + > xe_force_wake_put(gt_to_fw(gt), XE_FW_RENDER); > xe_pm_runtime_put(gt_to_xe(gt)); > } > diff --git a/drivers/gpu/drm/xe/xe_wa_oob.rules b/drivers/gpu/drm/xe/xe_wa_oob.rules > index 40438c3d9b72..7dad548dbe9f 100644 > --- a/drivers/gpu/drm/xe/xe_wa_oob.rules > +++ b/drivers/gpu/drm/xe/xe_wa_oob.rules > @@ -5,6 +5,7 @@ > 22011391025 PLATFORM(DG2) > 22012727170 SUBPLATFORM(DG2, G11) > 22012727685 SUBPLATFORM(DG2, G11) > +22016596838 PLATFORM(PVC) > 18020744125 PLATFORM(PVC) > 1509372804 PLATFORM(PVC), GRAPHICS_STEP(A0, C0) > 1409600907 GRAPHICS_VERSION_RANGE(1200, 1250) > -- > 2.47.1 >