All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dieter Nützel" <Dieter@nuetzel-hh.de>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: amd-devel <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/display: Fix crash in hwss_set_output_transfer_func()
Date: Thu, 06 Aug 2026 11:11:50 +0200	[thread overview]
Message-ID: <855de4d0b479bc35bbb906b7306aa359@nuetzel-hh.de> (raw)

Hello Alex,

where did you commited, this?
Can't find it your trees.

By the way:

Tested-by: Dieter Nützel <Dieter@nuetzel-hh.de>

https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/41557#note_3602165

Greetings,
   Dieter

PS Please CC me. I'm currently not on 'amd-devel'.


> Applied.  Thanks!
> 
> On Mon, Aug 3, 2026 at 8:58 AM Timur Kristóf <timur.kristof at 
> gmail.com> wrote:
> >
> > The pipe_ctx->plane_res.hubp pointer is NULL on all DCE
> > hardware, which causes a kernel NULL pointer dereference
> > on all Vega and older GPUs.
> >
> > Let's add a simple NULL check.
> >
> > Fixes: f879f53407f0 ("drm/amd/display: Refactor DPP_SET_OUTPUT_TRANSFER_FUNC to drop pipe_ctx")
> > Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
> > Cc: Tomasz Siemek <tomasz.siemek at amd.com>
> > ---
> >  drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > index 11411fa94665..5495e493b2eb 100644
> > --- a/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_hw_sequencer.c
> > @@ -1900,7 +1900,8 @@ void hwss_set_output_transfer_func(struct dc *dc, struct pipe_ctx *pipe_ctx)
> >                                 .xfm = pipe_ctx->plane_res.xfm,
> >                                 .dpp = pipe_ctx->plane_res.dpp,
> >                                 .mpc = dc->res_pool->mpc,
> > -                               .mpcc_id = pipe_ctx->plane_res.hubp->inst,
> > +                               .mpcc_id = pipe_ctx->plane_res.hubp ?
> > +                                               pipe_ctx->plane_res.hubp->inst : 0,
> >                                 .is_top_pipe = resource_is_pipe_type(pipe_ctx, OPP_HEAD),
> >                                 .stream = pipe_ctx->stream,
> >                         }
> > --
> > 2.55.0
> >

             reply	other threads:[~2026-08-06  9:18 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  9:11 Dieter Nützel [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-08-03 12:41 [PATCH] drm/amd/display: Fix crash in hwss_set_output_transfer_func() Timur Kristóf
2026-08-04 20:01 ` Viktor Jägersküpper
2026-08-05 13:53 ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=855de4d0b479bc35bbb906b7306aa359@nuetzel-hh.de \
    --to=dieter@nuetzel-hh.de \
    --cc=alexdeucher@gmail.com \
    --cc=amd-gfx@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.