From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AB1AE77188 for ; Wed, 8 Jan 2025 19:31:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EA29810E280; Wed, 8 Jan 2025 19:31:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PhO+U6Yk"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id 225D510E280 for ; Wed, 8 Jan 2025 19:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736364660; x=1767900660; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=M1uTnVe87z6iV5J80SGGDy3jZZZAY5YmAdSD/k10sVw=; b=PhO+U6YkcHDR7ohlw+B0GIQ60079YX9nLD4Dg2OhqhqbgKqJTSeNb3zd r+TBDpPOQjvzNcTotXU+IlsmUgggIWaQTREfcCUBl7Q2gEGMjxPiyU4Hd l0tq+C2aeWnCxySDGpR8tcV+p3K38RsHe7QcqjSMvrn//BBliToFcFqkW GnFF+q+xvtGTXvSMc9fOXtSn/1Pebj/BTJl/643GfwWqChZTues6IJFDt HldbypoRZ8AEC8ECev3hTTbz6TAAA0FdwWa742OGeyPfuxqG5aWoszdp+ Y/svoZ4CDiR0+CWuVTCpDLqKSenos6b8MMhmKNiClbrQVUTlDFhRhtiqH Q==; X-CSE-ConnectionGUID: 1Pepwqa4SY+v/w99pL7Uxw== X-CSE-MsgGUID: uuSJOsAfTreyLHDZf3fDUA== X-IronPort-AV: E=McAfee;i="6700,10204,11309"; a="36507751" X-IronPort-AV: E=Sophos;i="6.12,299,1728975600"; d="scan'208";a="36507751" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2025 11:30:59 -0800 X-CSE-ConnectionGUID: ksdBxrRvT0mvOSybrkq2eg== X-CSE-MsgGUID: EzKEHr2zQcGV1t6ZMrHZTQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="107226365" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jan 2025 11:30:59 -0800 Date: Wed, 08 Jan 2025 11:30:59 -0800 Message-ID: <855xmpayrw.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Belgaumkar, Vinay" Cc: Rodrigo Vivi , Subject: Re: [PATCH 2/3] drm/i915/guc/slpc: Enable GuC SLPC default strategies In-Reply-To: <9620547a-6512-4d54-bc11-08826da1adaf@intel.com> References: <20250108141318.63823-1-rodrigo.vivi@intel.com> <20250108141318.63823-3-rodrigo.vivi@intel.com> <9620547a-6512-4d54-bc11-08826da1adaf@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Wed, 08 Jan 2025 11:11:53 -0800, Belgaumkar, Vinay wrote: > > > On 1/8/2025 6:13 AM, Rodrigo Vivi wrote: > > The Balancer and DCC strategies were left off on a fear that > > these strategies would conflict with the i915's waitboost. > > However, these strategies are only active in certain conditions where > > the system is TDP limited. So, they don't conflict, but help the > > waitboost by guaranteeing a bit more of GT frequency. > > > > Without these strategies we were likely leaving some performance > > behind on some scenarious. > > s/scenarious/scenarios > > We should also mention that the platform defaults for enabling/disabling > DCC/Balancer will now be chosen by GuC. > > Reviewed-by: Vinay Belgaumkar > > > > > Cc: Vinay Belgaumkar > > Signed-off-by: Rodrigo Vivi Does this need a Fixes: and Cc:stable?