From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Mashak <mrv@mojatatu.com>
Subject: Re: [PATCH net 5/5] net sched actions: fix misleading text strings in pedit action
Date: Tue, 19 Jun 2018 13:15:53 -0400
Message-ID: <85602eg0ja.fsf@mojatatu.com>
References: <1529427368-17129-1-git-send-email-mrv@mojatatu.com>
        <1529427368-17129-6-git-send-email-mrv@mojatatu.com>
        <20180619100408.42155193@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain
Cc: davem@davemloft.net, netdev@vger.kernel.org, kernel@mojatatu.com,
        jhs@mojatatu.com, xiyou.wangcong@gmail.com, jiri@resnulli.us
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f54.google.com ([209.85.214.54]:50781 "EHLO
        mail-it0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S966646AbeFSRPy (ORCPT
        <rfc822;netdev@vger.kernel.org>); Tue, 19 Jun 2018 13:15:54 -0400
Received: by mail-it0-f54.google.com with SMTP id u4-v6so1483600itg.0
        for <netdev@vger.kernel.org>; Tue, 19 Jun 2018 10:15:54 -0700 (PDT)
In-Reply-To: <20180619100408.42155193@xeon-e3> (Stephen Hemminger's message of
        "Tue, 19 Jun 2018 10:04:08 -0700")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Stephen Hemminger <stephen@networkplumber.org> writes:

> On Tue, 19 Jun 2018 12:56:08 -0400

[...]

>> @@ -326,12 +326,12 @@ static int tcf_pedit(struct sk_buff *skb, const struct tc_action *a,
>>  			}
>>  
>>  			if (offset % 4) {
>> -				pr_info("tc filter pedit offset must be on 32 bit boundaries\n");
>> +				pr_info("tc action pedit offset must be on 32 bit boundaries\n");
>>  				goto bad;
>>  			}
>>  
>>  			if (!offset_valid(skb, hoffset + offset)) {
>> -				pr_info("tc filter pedit offset %d out of bounds\n",
>> +				pr_info("tc action pedit offset %d out of bounds\n",
>>  					hoffset + offset);
>>  				goto bad;
>
> Time to convert these to netlink extack reporting?

Yes, this is planned in next patches.