Re: [PATCH] build: fix meson warning about using compiler warning flags

[Thomas Monjalon <thomas@monjalon.net>]

21/01/2022 17:41, Luca Boccassi:
> On Fri, 2022-01-21 at 15:53 +0000, Bruce Richardson wrote:
> > Each build, meson would issue a warning reporting that the
> > "warning_level" setting should be used in place of adding -Wextra
> > directly to our build commands. Testing with meson 0.61 shows that the
> > only difference for gcc and clang builds between warning levels 1 and
> > 2 is the addition of -Wextra, so we can remove the warning by deleting
> > our explicit set of Wextra and changing the build defaults to
> > warning_level 2.
> > 
> > Fixes: 524a0d5d66b9 ("build: enable extra warnings with meson")
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > 
> > NOTE1: Not putting CC stable for this patch, I don't believe it's worth
> > the risk of backporting.
> > 
> > NOTE2: For reference, when building a test "hello world" project with
> > different warning levels, the following flags are used by meson:
> > 
> > warning_level=0: <none>
> > warning_level=1: -Wall -Winvalid-pch
> > warning_level=2: -Wall -Winvalid-pch -Wextra
> > warning_level=3: -Wall -Winvalid-pch -Wextra -Wpedantic
> > ---
> 
> Acked-by: Luca Boccassi <bluca@debian.org>

Applied, thanks.