From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:36650)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1a1H8y-0004zS-8o
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:12:41 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1a1H8v-0007K0-3L
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:12:40 -0500
Received: from mx3-phx2.redhat.com ([209.132.183.24]:45568)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mlureau@redhat.com>) id 1a1H8u-0007Ji-Td
	for qemu-devel@nongnu.org; Tue, 24 Nov 2015 12:12:37 -0500
Date: Tue, 24 Nov 2015 12:12:31 -0500 (EST)
From: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau <mlureau@redhat.com>
Message-ID: <856433363.16560463.1448385151683.JavaMail.zimbra@redhat.com>
In-Reply-To: <1448384789-14830-2-git-send-email-armbru@redhat.com>
References: <1448384789-14830-1-git-send-email-armbru@redhat.com>
	<1448384789-14830-2-git-send-email-armbru@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-2.5 1/5] qemu-doc: Fix ivshmem example
	markup
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: marcandre lureau <marcandre.lureau@redhat.com>, claudio fontana <claudio.fontana@huawei.com>, qemu-devel@nongnu.org



----- Original Message -----
> Use @var{foo} like we do everywhere else, not <foo>.
>=20
> Signed-off-by: Markus Armbruster <armbru@redhat.com>

Reviewed-by: Marc-Andr=C3=A9 Lureau <marcandre.lureau@redhat.com>

> ---
>  qemu-doc.texi | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/qemu-doc.texi b/qemu-doc.texi
> index 460ab71..c9b7069 100644
> --- a/qemu-doc.texi
> +++ b/qemu-doc.texi
> @@ -1256,7 +1256,7 @@ zero-copy communication to the application level of=
 the
> guests.  The basic
>  syntax is:
> =20
>  @example
> -qemu-system-i386 -device ivshmem,size=3D<size in format accepted by
> -m>[,shm=3D<shm name>]
> +qemu-system-i386 -device ivshmem,size=3D@var{size}[,shm=3D@var{shm-name}=
]
>  @end example
> =20
>  If desired, interrupts can be sent between guest VMs accessing the same
>  shared
> @@ -1267,12 +1267,12 @@ memory server is:
> =20
>  @example
>  # First start the ivshmem server once and for all
> -ivshmem-server -p <pidfile> -S <path> -m <shm name> -l <shm size> -n
> <vectors n>
> +ivshmem-server -p @var{pidfile} -S @var{path} -m @var{shm-name} -l
> @var{shm-size} -n @var{vectors}
> =20
>  # Then start your qemu instances with matching arguments
> -qemu-system-i386 -device ivshmem,size=3D<shm size>,vectors=3D<vectors
> n>,chardev=3D<id>
> +qemu-system-i386 -device
> ivshmem,size=3D@var{shm-size},vectors=3D@var{vectors},chardev=3D@var{id}
>                   [,msi=3Don][,ioeventfd=3Don][,role=3Dpeer|master]
> -                 -chardev socket,path=3D<path>,id=3D<id>
> +                 -chardev socket,path=3D@var{path},id=3D@var{id}
>  @end example
> =20
>  When using the server, the guest will be assigned a VM ID (>=3D0) that a=
llows
>  guests
> --
> 2.4.3
>=20
>=20