From: David Kastrup <dak@gnu.org>
To: "Wincent Colaiuta" <win@wincent.com>
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>, git@vger.kernel.org
Subject: Re: --exit-code (and --quiet) broken in git-diff?
Date: Sun, 12 Aug 2007 13:31:38 +0200 [thread overview]
Message-ID: <85643lq99h.fsf@lola.goethe.zz> (raw)
In-Reply-To: <24332.88.10.191.55.1186917895.squirrel@secure.wincent.com> (Wincent Colaiuta's message of "Sun\, 12 Aug 2007 06\:24\:55 -0500 \(CDT\)")
"Wincent Colaiuta" <win@wincent.com> writes:
> René Scharfe wrote:
>>
>> git diff passes the output through your pager by default, so you see the
>> exit code of that instead of diff's. Set PAGER=cat or redirect the
>> output to /dev/null to get rid of it.
>
> Ah, thanks very much René!
I think I would call that a mistake. However, I don't see that fixing
it would actually be useful: if a pager gets called, this means that
git-diff might die with SIGPIPE (when the user quits the pager), and
that in turn has pretty much no meaning. So one really needs to
redirect the output, anyway.
--
David Kastrup, Kriemhildstr. 15, 44793 Bochum
next prev parent reply other threads:[~2007-08-12 11:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-11 23:12 --exit-code (and --quiet) broken in git-diff? Wincent Colaiuta
2007-08-12 9:40 ` René Scharfe
2007-08-12 11:24 ` Wincent Colaiuta
2007-08-12 11:31 ` David Kastrup [this message]
2007-08-12 13:02 ` Steven Grimm
2007-08-12 13:29 ` David Kastrup
2007-08-12 16:57 ` Wincent Colaiuta
2007-08-12 11:33 ` Steffen Prohaska
2007-08-12 17:46 ` [PATCH] diff: don't run pager if user asked for a diff style exit code René Scharfe
2007-08-13 9:57 ` Wincent Colaiuta
2007-08-13 10:23 ` David Kastrup
2007-08-13 23:42 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85643lq99h.fsf@lola.goethe.zz \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=rene.scharfe@lsrfire.ath.cx \
--cc=win@wincent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.