From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB87FC2D0DB for ; Mon, 27 Jan 2020 21:24:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5C66824656 for ; Mon, 27 Jan 2020 21:24:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XBfkfuQt" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C66824656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id B44F2829; Mon, 27 Jan 2020 22:23:35 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz B44F2829 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1580160265; bh=4U6PujJcY149DCTTrmNxDXUXN75b4efq+9vrChuIGhk=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XBfkfuQtiaG0yQ04ZRAl5wdbBgJ2pvhw4fCZlJxiLxCGEEbGAIstkbk70VAfLEeNp BgaI8P8RGZtaLqudkpZzwsM9Wn2oogWW8vooXSdS/Fub8Q6AAktNg4cInP5GgiXVIw r4H9p/2qmNV3kpW0kVPNoNTBgRZqLXaQP8tV9wng= Received: from vmi242170.contaboserver.net (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 43A83F80276; Mon, 27 Jan 2020 22:21:31 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B148BF80259; Mon, 27 Jan 2020 22:21:21 +0100 (CET) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 18E70F80218 for ; Mon, 27 Jan 2020 22:21:14 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 18E70F80218 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 27 Jan 2020 13:21:10 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,371,1574150400"; d="scan'208";a="231649971" Received: from ngstahl-mobl1.amr.corp.intel.com (HELO [10.254.190.105]) ([10.254.190.105]) by orsmga006.jf.intel.com with ESMTP; 27 Jan 2020 13:21:11 -0800 To: Cezary Rojewski , alsa-devel@alsa-project.org References: <20200127121243.15813-1-cezary.rojewski@intel.com> <20200127121243.15813-8-cezary.rojewski@intel.com> From: Pierre-Louis Bossart Message-ID: <856e030c-e6ee-75dd-30e2-5ece864ec2fa@linux.intel.com> Date: Mon, 27 Jan 2020 15:20:05 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <20200127121243.15813-8-cezary.rojewski@intel.com> Content-Language: en-US Cc: broonie@kernel.org, tiwai@suse.com, lgirdwood@gmail.com Subject: Re: [alsa-devel] [PATCH v2 07/11] ASoC: SOF: Implement Probe IPC API X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" > diff --git a/sound/soc/sof/sof-priv.h b/sound/soc/sof/sof-priv.h > index bc2337cf1142..9fa6fb6c7b93 100644 > --- a/sound/soc/sof/sof-priv.h > +++ b/sound/soc/sof/sof-priv.h > @@ -387,6 +387,9 @@ struct snd_sof_dev { > wait_queue_head_t waitq; > int code_loading; > > + /* probes */ > + unsigned int extractor; > + if we can rename this extractor_stream_tag it'd be more explicit for future code evolutions. we have too many things in this sof-dev structures and it's hard to keep track of what is used for what without self-explanatory naming conventions. Thanks! _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel