From mboxrd@z Thu Jan 1 00:00:00 1970 From: devzero@web.de Subject: pata_winbond doesn`t unregister from sysfs - bug? Date: Fri, 04 Jan 2008 14:52:25 +0100 Message-ID: <85735256@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit Return-path: Received: from fmmailgate05.web.de ([217.72.192.243]:43270 "EHLO fmmailgate05.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbYADNw2 (ORCPT ); Fri, 4 Jan 2008 08:52:28 -0500 Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: linux-ide@vger.kernel.org Cc: alan@lxorguk.ukuu.org.uk, bzolnier@gmail.com Hi, this looks like a bug to me (see below) happens on 2.6.24rc6 and i came across this by chance... i`m here on notebook with vmware only, so i cannot test if this happens on real hardware, too. maybe someone can try "modprobe pata_winbond" twice and see if this is reproduceable.... regards Roland opensuse103:~ # modprobe pata_winbond FATAL: Error inserting pata_winbond (/lib/modules/2.6.24-rc6-vanilla+suseconfig/kernel/drivers/ata/pata_winbond.ko): No such device dmesg: scsi1 : pata_winbond ata1: PATA max PIO4 cmd 0x1f0 ctl 0x3f6 irq 14 opensuse103:~ # rmmod pata_winbond ERROR: Module pata_winbond does not exist in /proc/modules opensuse103:~ # lsmod |grep winbond opensuse103:~ # ok, it did not load (as expected) but on second load: opensuse103:~ # modprobe pata_winbond FATAL: Error inserting pata_winbond (/lib/modules/2.6.24-rc6-vanilla+suseconfig/kernel/drivers/ata/pata_winbond.ko): No such device dmesg: sysfs: duplicate filename 'pata_winbond.0' can not be created WARNING: at fs/sysfs/dir.c:424 sysfs_add_one() Pid: 2472, comm: modprobe Not tainted 2.6.24-rc6-vanilla+suseconfig #11 [] sysfs_add_one+0x54/0xb8 [] create_dir+0x3c/0x6c [] sysfs_create_dir+0x2d/0x40 [] kobject_get+0xf/0x13 [] kobject_add+0xe8/0x18f [] kobject_set_name+0x81/0x94 [] device_add+0x8b/0x462 [] platform_device_add+0xe8/0x116 [] platform_device_register_simple+0x34/0x4a [] winbond_init+0x112/0x29c [pata_winbond] [] sys_init_module+0x1675/0x172d [] do_sync_read+0x0/0x10a [] do_sync_read+0xc7/0x10a [] __do_softirq+0x75/0xe1 [] __request_region+0x0/0x74 [] sysenter_past_esp+0x6b/0xa9 ======================= kobject_add failed for pata_winbond.0 with -EEXIST, don't try to register things with the same name in the same directory. Pid: 2472, comm: modprobe Not tainted 2.6.24-rc6-vanilla+suseconfig #11 [] kobject_add+0x13c/0x18f [] kobject_add+0x15d/0x18f [] kobject_set_name+0x81/0x94 [] device_add+0x8b/0x462 [] platform_device_add+0xe8/0x116 [] platform_device_register_simple+0x34/0x4a [] winbond_init+0x112/0x29c [pata_winbond] [] sys_init_module+0x1675/0x172d [] do_sync_read+0x0/0x10a [] do_sync_read+0xc7/0x10a [] __do_softirq+0x75/0xe1 [] __request_region+0x0/0x74 [] sysenter_past_esp+0x6b/0xa9 ======================= opensuse103:/ # find /sys |grep winbond /sys/devices/platform/pata_winbond.0 /sys/devices/platform/pata_winbond.0/uevent /sys/devices/platform/pata_winbond.0/power /sys/devices/platform/pata_winbond.0/power/wakeup /sys/devices/platform/pata_winbond.0/modalias /sys/devices/platform/pata_winbond.0/subsystem /sys/devices/platform/pata_winbond.0/host1 /sys/devices/platform/pata_winbond.0/host1/uevent /sys/devices/platform/pata_winbond.0/host1/power /sys/devices/platform/pata_winbond.0/host1/power/wakeup /sys/bus/platform/devices/pata_winbond.0 opensuse103:/ # lspci -vvv 00:00.0 Host bridge: Intel Corporation 440BX/ZX/DX - 82443BX/ZX/DX Host bridge (rev 01) Subsystem: VMware Inc virtualHW v3 Control: I/O- Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap+ 66MHz- UDF- FastB2B- ParErr- DEVSEL=medium >TAbort- SERR- TAbort- SERR- TAbort- Reset- FastB2B+ 00:07.0 ISA bridge: Intel Corporation 82371AB/EB/MB PIIX4 ISA (rev 08) Subsystem: VMware Inc virtualHW v3 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- SERR- TAbort- Reset- FastB2B- Capabilities: [40] Subsystem: VMware Inc Unknown device 0790 02:00.0 Ethernet controller: Advanced Micro Devices [AMD] 79c970 [PCnet32 LANCE] (rev 10) Subsystem: Advanced Micro Devices [AMD] PCnet - Fast 79C971 Control: I/O+ Mem+ BusMaster+ SpecCycle- MemWINV- VGASnoop- ParErr- Stepping- SERR- FastB2B- Status: Cap- 66MHz- UDF- FastB2B+ ParErr- DEVSEL=medium >TAbort- SERR-