Re: [PATCH 2/5] drm/xe/oa/uapi: Add gt_id to struct drm_xe_oa_unit

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 26 Nov 2025 12:42:53 -0800, Matthew Brost wrote:
>
> > diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> > index 47853659a705e..ec09b281eafe7 100644
> > --- a/include/uapi/drm/xe_drm.h
> > +++ b/include/uapi/drm/xe_drm.h
> > @@ -1676,12 +1676,16 @@ struct drm_xe_oa_unit {
> >  #define DRM_XE_OA_CAPS_OA_BUFFER_SIZE	(1 << 2)
> >  #define DRM_XE_OA_CAPS_WAIT_NUM_REPORTS	(1 << 3)
> >  #define DRM_XE_OA_CAPS_OAM		(1 << 4)
> > +#define DRM_XE_OA_CAPS_OA_UNIT_GT_ID	(1 << 5)
> >
> >	/** @oa_timestamp_freq: OA timestamp freq */
> >	__u64 oa_timestamp_freq;
> >
> > +	/** @gt_id: gt id for this OA unit */
> > +	__u64 gt_id;
>
> u64 seems like overkill. Maybe a u32 or u16 to save some bits for the future?

Sure, will change to u16 before merging.

>
> > +
> >	/** @reserved: MBZ */
> > -	__u64 reserved[4];
> > +	__u64 reserved[3];
> >
> >	/** @num_engines: number of engines in @eci array */
> >	__u64 num_engines;
> > --
> > 2.48.1
> >