From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90EF5E77197 for ; Thu, 9 Jan 2025 21:32:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 33E9A10E48D; Thu, 9 Jan 2025 21:32:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="MKKt917V"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 729A710E48D for ; Thu, 9 Jan 2025 21:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736458363; x=1767994363; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=eYe6Y3YYOyJUwnyLW2Uv3tt0FmxU+Wimks0EnWa0QBw=; b=MKKt917VDyEZTfdIr6nagk0wk5stpYQECOgtyWImT6GmIJyCiWZOy/Bi aEnFV6J0kcRplHz8pcgxW7mR7baInxzBKXxn89dIjz8J4jdaFoGbpRlLP QPpqnMy+6vnd5bEEC0KbfIwoRHKjM7UKvuvyPMAiMXqD7lncxmSBMOQh+ LPi+BfussrhGwlr1Y7ax/BNPnrNxrt/yM9OZbYSVn8PWeLSvPOFx/2w4l IXuCwOhLIyNtTbKDcCbDROpd5C2zOqrjT/Qq+7W7+3cLI0VcHUOwfXINQ zKr4XV13gw5PjcRMjbpyzCgk0R/BpeGkMQtYPV3H6xJ50V7ZOBFAnwQ/0 A==; X-CSE-ConnectionGUID: Y8kHGlW8SfC7DpOcGzo+Dw== X-CSE-MsgGUID: qOS3wownTKWjEr3+ZaQMcQ== X-IronPort-AV: E=McAfee;i="6700,10204,11310"; a="59215259" X-IronPort-AV: E=Sophos;i="6.12,302,1728975600"; d="scan'208";a="59215259" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2025 13:32:43 -0800 X-CSE-ConnectionGUID: ly7iKgUvR5SiNR47E3gGmQ== X-CSE-MsgGUID: gR4XYoK1TsGBYhNoXkXybw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,302,1728975600"; d="scan'208";a="108443308" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Jan 2025 13:32:43 -0800 Date: Thu, 09 Jan 2025 13:32:42 -0800 Message-ID: <857c73vfk5.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Rodrigo Vivi Cc: "Belgaumkar, Vinay" , Subject: Re: [PATCH 2/3] drm/i915/guc/slpc: Enable GuC SLPC default strategies In-Reply-To: References: <20250108141318.63823-1-rodrigo.vivi@intel.com> <20250108141318.63823-3-rodrigo.vivi@intel.com> <9620547a-6512-4d54-bc11-08826da1adaf@intel.com> <855xmpayrw.wl-ashutosh.dixit@intel.com> <858qrkva32.wl-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Thu, 09 Jan 2025 11:00:36 -0800, Rodrigo Vivi wrote: > > On Wed, Jan 08, 2025 at 09:18:41PM -0800, Dixit, Ashutosh wrote: > > On Wed, 08 Jan 2025 13:19:16 -0800, Rodrigo Vivi wrote: > > > > > > > Hi Rodrigo, > > > > > On Wed, Jan 08, 2025 at 11:30:59AM -0800, Dixit, Ashutosh wrote: > > > > On Wed, 08 Jan 2025 11:11:53 -0800, Belgaumkar, Vinay wrote: > > > > > > > > > > > > > > > On 1/8/2025 6:13 AM, Rodrigo Vivi wrote: > > > > > > The Balancer and DCC strategies were left off on a fear that > > > > > > these strategies would conflict with the i915's waitboost. > > > > > > However, these strategies are only active in certain conditions where > > > > > > the system is TDP limited. So, they don't conflict, but help the > > > > > > waitboost by guaranteeing a bit more of GT frequency. > > > > > > > > > > > > Without these strategies we were likely leaving some performance > > > > > > behind on some scenarious. > > > > > > > > > > s/scenarious/scenarios > > > > > > I do need to re-enable my spell checker during git commit :) > > > > > > > > > > > > > We should also mention that the platform defaults for enabling/disabling > > > > > DCC/Balancer will now be chosen by GuC. > > > > > > > > > > Reviewed-by: Vinay Belgaumkar > > > > > > > > > > > > > > > > > Cc: Vinay Belgaumkar > > > > > > Signed-off-by: Rodrigo Vivi > > > > > > > > Does this need a Fixes: and Cc:stable? > > > > > > nope... this is more like enabling a new feature... > > > > Hmm, if this really improves performance, as the commit message seems to > > suggest, why wouldn't we want this in stable, or at least LTS, kernels? So > > why isn't this a performance bug fix? > > hmm... performance is not listed in the stable-rules as a obvious case, and > it is not a regression, is really a new feature, that has the potential to > find some later corner cases. So, safer to just enable as a new feature... > > Also a feature that is really a corner case for the end user... needs to > be using both cpu and gpu with high utilization and a limited power budget. > General benchmarks and usages don't hit this scenario very easily. OK, fair enough :)