From: Gabriel Krisman Bertazi <krisman@collabora.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>
Subject: Re: How to add Unicode character tables to the kernel?
Date: Mon, 01 Apr 2019 15:23:57 -0400 [thread overview]
Message-ID: <857ecd5y2a.fsf@collabora.com> (raw)
In-Reply-To: <CAHk-=wg4OqHpbckCcan73TXkB-rxS1C2M53uLs27Gw2w4PzR5g@mail.gmail.com> (Linus Torvalds's message of "Mon, 1 Apr 2019 10:51:39 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Sun, Mar 31, 2019 at 4:09 PM Theodore Ts'o <tytso@mit.edu> wrote:
>>
>> The question is how to do this, with different tradeoffs. One is to
>> simply include a utf8data.h file, which will be 320k. That might
>> sound large, but in fs/nls there are 3544k worth of similar files.
>> Some are relatively small --- only 16k. But others are quite large
>> --- 480k to 856k. The table for Chinese character set is such an
>> example. So in comparison, the 320k size of utf8data.h is quite
>> compact.
>>
>> The problem with this solution is that the files in fs/nls, and the
>> proposed utf8data.h, are generated files.
>
> Oh, we definitely don't want to copy the original huge tables, and we
> don't even *want* people to edit those things in the first place.
>
> So generated files are fine. It's not like the source data isn't
> public, and yes, the commit message should have a pointer to it and
> how to get the source and the generated files. But no, we shouldn't
> feel like we should encourage people to be able to generate their own
> modified unicode tables.
Thanks! Ted, as you know, the current patchset depends on the original
tables, so I will adapt it to only include the generated files and
submit a new version to the mailing list.
--
Gabriel Krisman Bertazi
prev parent reply other threads:[~2019-04-01 19:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-31 23:09 How to add Unicode character tables to the kernel? Theodore Ts'o
2019-04-01 17:51 ` Linus Torvalds
2019-04-01 19:23 ` Gabriel Krisman Bertazi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857ecd5y2a.fsf@collabora.com \
--to=krisman@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.