From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE978C433EF for ; Mon, 1 Nov 2021 05:23:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 97844610A0 for ; Mon, 1 Nov 2021 05:23:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229528AbhKAF0b (ORCPT ); Mon, 1 Nov 2021 01:26:31 -0400 Received: from mga17.intel.com ([192.55.52.151]:10897 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229502AbhKAF0b (ORCPT ); Mon, 1 Nov 2021 01:26:31 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="211715451" X-IronPort-AV: E=Sophos;i="5.87,198,1631602800"; d="scan'208";a="211715451" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2021 22:23:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,198,1631602800"; d="scan'208";a="449138280" Received: from unknown (HELO [10.239.154.43]) ([10.239.154.43]) by orsmga003.jf.intel.com with ESMTP; 31 Oct 2021 22:23:55 -0700 Message-ID: <8592a48d-0131-86bf-586a-d33e7989e523@intel.com> Date: Mon, 1 Nov 2021 13:23:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 1/2] i2c: virtio: disable timeout handling Content-Language: en-US To: Vincent Whitchurch Cc: Viresh Kumar , Greg KH , Wolfram Sang , "virtualization@lists.linux-foundation.org" , "linux-i2c@vger.kernel.org" , "linux-kernel@vger.kernel.org" , kernel , Conghui Chen References: <20211019143748.wrpqopj2hmpvblh4@vireshk-i7> <94aa39ab-4ed6-daee-0402-f58bfed0cadd@intel.com> <8e182ea8-5016-fa78-3d77-eefba7d58612@intel.com> <20211020064128.y2bjsbdmpojn7pjo@vireshk-i7> <01d9c992-28cc-6644-1e82-929fc46f91b4@intel.com> <20211020105554.GB9985@axis.com> <20211020110316.4x7tnxonswjuuoiw@vireshk-i7> <20211029122450.GB24060@axis.com> From: Jie Deng In-Reply-To: <20211029122450.GB24060@axis.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On 2021/10/29 20:24, Vincent Whitchurch wrote: > On Thu, Oct 21, 2021 at 05:30:28AM +0200, Jie Deng wrote: >> For this moment, we can solve the problem by using a hardcoded big >> value or disabling the timeout. > Is that an Acked-by on this patch which does the latter? Yes, you can add my Acked-by. Let's see if other people still have different opinions. > >> Over the long term, I think the backend should provide that timeout >> value and guarantee that its processing time should not exceed that >> value. > If you mean that the spec should be changed to allow the virtio driver > to be able to program a certain timeout for I2C transactions in the > virtio device, yes, that does sound reasonable. Due to changes in my work, I will pass my virtio-i2c maintenance to Conghui. She may work on this in the future. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC066C433EF for ; Mon, 1 Nov 2021 05:24:03 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 49F7461078 for ; Mon, 1 Nov 2021 05:24:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 49F7461078 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 0F39F40105; Mon, 1 Nov 2021 05:24:03 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Ptqi8RjRHwki; Mon, 1 Nov 2021 05:24:02 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id C1615400FE; Mon, 1 Nov 2021 05:24:01 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 98FA7C0012; Mon, 1 Nov 2021 05:24:01 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [IPv6:2605:bc80:3010::137]) by lists.linuxfoundation.org (Postfix) with ESMTP id E2DA4C000E for ; Mon, 1 Nov 2021 05:23:59 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id BE0B140105 for ; Mon, 1 Nov 2021 05:23:59 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id taR5rMAQCSRW for ; Mon, 1 Nov 2021 05:23:59 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by smtp4.osuosl.org (Postfix) with ESMTPS id 23915400FE for ; Mon, 1 Nov 2021 05:23:58 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10154"; a="230900180" X-IronPort-AV: E=Sophos;i="5.87,198,1631602800"; d="scan'208";a="230900180" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Oct 2021 22:23:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,198,1631602800"; d="scan'208";a="449138280" Received: from unknown (HELO [10.239.154.43]) ([10.239.154.43]) by orsmga003.jf.intel.com with ESMTP; 31 Oct 2021 22:23:55 -0700 Message-ID: <8592a48d-0131-86bf-586a-d33e7989e523@intel.com> Date: Mon, 1 Nov 2021 13:23:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.2.1 Subject: Re: [PATCH 1/2] i2c: virtio: disable timeout handling Content-Language: en-US To: Vincent Whitchurch References: <20211019143748.wrpqopj2hmpvblh4@vireshk-i7> <94aa39ab-4ed6-daee-0402-f58bfed0cadd@intel.com> <8e182ea8-5016-fa78-3d77-eefba7d58612@intel.com> <20211020064128.y2bjsbdmpojn7pjo@vireshk-i7> <01d9c992-28cc-6644-1e82-929fc46f91b4@intel.com> <20211020105554.GB9985@axis.com> <20211020110316.4x7tnxonswjuuoiw@vireshk-i7> <20211029122450.GB24060@axis.com> From: Jie Deng In-Reply-To: <20211029122450.GB24060@axis.com> Cc: Viresh Kumar , "linux-kernel@vger.kernel.org" , "virtualization@lists.linux-foundation.org" , Wolfram Sang , kernel , "linux-i2c@vger.kernel.org" , Greg KH , Conghui Chen X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" On 2021/10/29 20:24, Vincent Whitchurch wrote: > On Thu, Oct 21, 2021 at 05:30:28AM +0200, Jie Deng wrote: >> For this moment, we can solve the problem by using a hardcoded big >> value or disabling the timeout. > Is that an Acked-by on this patch which does the latter? Yes, you can add my Acked-by. Let's see if other people still have different opinions. > >> Over the long term, I think the backend should provide that timeout >> value and guarantee that its processing time should not exceed that >> value. > If you mean that the spec should be changed to allow the virtio driver > to be able to program a certain timeout for I2C transactions in the > virtio device, yes, that does sound reasonable. Due to changes in my work, I will pass my virtio-i2c maintenance to Conghui. She may work on this in the future. _______________________________________________ Virtualization mailing list Virtualization@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/virtualization