From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B962441D for ; Mon, 24 Jun 2024 11:32:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=93.104.207.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228752; cv=none; b=OWexvCCglDo8dwNlDIKHd3PS/TRD6oiYqd1MnSfhhd+Nxk3yLapCqq7/UpxM/FMQCxEvkNqOfdR7oYrlqG8RXYtz1pvP4hEHpbTCvXSP/GCe8vN6sF+vpT4UuFVNWfzHgqkq+rsN27LG7HYTqmpOim8JARL06XmvTD7nLwrqsP8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1719228752; c=relaxed/simple; bh=7jlo9vmhtWKTResIq0eDD/qPIJzSgx51/e3patMJCKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CUv1lsgArFT6zEvnIZxXYys8OUi+QA+63CIxDu5L4yop/CtXvUWlDdbzQU0dgr788VOikg0s7RKmqTCcbkihENl/VTTO1SFiuSx/R2XA+CJ917gWvxoQT+tWodQI47QDzZmFtXuEhWcclfW6oYrJwEsqmDFVP1kDiWv2eigjrAA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com; spf=pass smtp.mailfrom=ew.tq-group.com; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b=jzk8zOGz; dkim=fail (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b=J/ZYT6ZZ reason="key not found in DNS"; arc=none smtp.client-ip=93.104.207.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ew.tq-group.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tq-group.com header.i=@tq-group.com header.b="jzk8zOGz"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=ew.tq-group.com header.i=@ew.tq-group.com header.b="J/ZYT6ZZ" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1719228748; x=1750764748; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=HS0w/FAC4Vg1rsGlmB0DrwqRXeG8EmTG+BPwYRmz0Bo=; b=jzk8zOGzp6uniq/W8e9ZG4hsjdCJBPScwQ/hyhcavWOsNn28FHtORJck vT1hVLg+YYoz92Ulkc2zFj9zULhcj8U7X57WneeIIDAKvRqLGoAtWwhdw Tv4mU2zOJfTuS9wyHY+FfKy8OKnZ5d+tnd1qoHsPRIi5DfCQ4zh5pTWHP 4B4XK9Jt/1k+dApVNGbIYTfhpoaDNSATMnNyqxMqpaTF7t3395qHGmB3y 8uhPkq2UlHSwWma84w6FLkLSQ42C7BM7ChY1vQ8SmU9kHIUFpH9nIVTMP dKi4TzdQk57ELUkrepDZVbm2/fFaqGPeIWlkMd3KsLYlrfEHSRPrfUHss A==; X-CSE-ConnectionGUID: xutlt1bvR1OPgmKEzE8qrw== X-CSE-MsgGUID: 0ZaALeZKQNuLTK+a8XFTmg== X-IronPort-AV: E=Sophos;i="6.08,261,1712613600"; d="scan'208";a="37550994" Received: from vmailcow01.tq-net.de ([10.150.86.48]) by mx1.tq-group.com with ESMTP; 24 Jun 2024 13:32:26 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AA73B161461; Mon, 24 Jun 2024 13:32:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ew.tq-group.com; s=dkim; t=1719228742; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=HS0w/FAC4Vg1rsGlmB0DrwqRXeG8EmTG+BPwYRmz0Bo=; b=J/ZYT6ZZPm0j+qJ4XydMuPOr/DBjQtDvmdFLU+zCLT2h1BaF/9ZdN6AMbIEAcBFZHOufHo dY71HZUtLEoVzDdVUenSGEbmC9Htj7QxPLqUzfdN4VEPC6+XmzXZ/wnv3zRAO9jfin2YbP BTPYjfEK0tJXbllPhenw25hwg59vJ3BfVqrsD9tffJ6zY8lalYhJEWP2xkkzWNtXHr29IP 2omtKCwu6I5hltQ+s/T0yYI7+LslkgRXYZRal3CUsTjGdpUaDGgRs5lOzWG+54od/Pkme+ cFyVcHhTOZmaG51c+KlgFFdeOkjT9u1kB70EsnbN1e+OV529ORP8gwloyvVoTw== From: Alexander Stein To: Marek Vasut , Stefan Agner , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Dmitry Baryshkov Cc: dri-devel@lists.freedesktop.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dmitry Baryshkov Subject: Re: [PATCH] drm/lcdif: switch to DRM_BRIDGE_ATTACH_NO_CONNECTOR Date: Mon, 24 Jun 2024 13:32:20 +0200 Message-ID: <859620673.0ifERbkFSE@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240624-mxc-lcdif-bridge-attach-v1-1-37e8c5d5d934@linaro.org> References: <20240624-mxc-lcdif-bridge-attach-v1-1-37e8c5d5d934@linaro.org> Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Last-TLS-Session-Version: TLSv1.3 Hi, Am Montag, 24. Juni 2024, 12:31:46 CEST schrieb Dmitry Baryshkov: > Existing in-kernel device trees use LCDIF with the dsim + adv7533, dsim > + tc358762 or with ldb + panel_bridge. All these combinations support > using DRM_BRIDGE_ATTACH_NO_CONNECTOR for bridge attachment. >=20 > Change lcdif driver to use this flag when attaching the bridge and > create drm_bridge_connector afterwards. >=20 > Signed-off-by: Dmitry Baryshkov > --- > Note: compile-tested only. I gave it a try, but it doesn't work. Despite DSI output it also breaks HDMI output, where I at least some error messages: [drm:drm_bridge_attach] *ERROR* failed to attach bridge /soc@0/bus@32c00000= /hdmi@32fd8000 to encoder None-37: -22 [drm:drm_bridge_attach] *ERROR* failed to attach bridge /soc@0/bus@32c00000= /display-bridge@32fc4000 to encoder None-37: -22 imx-lcdif 32fc6000.display-controller: error -EINVAL: Failed to attach brid= ge for endpoint0 imx-lcdif 32fc6000.display-controller: error -EINVAL: Cannot connect bridge imx-lcdif 32fc6000.display-controller: probe with driver imx-lcdif failed w= ith error -22 Best regards, Alexander > --- > drivers/gpu/drm/mxsfb/lcdif_drv.c | 14 +++++++++++++- > 1 file changed, 13 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/mxsfb/lcdif_drv.c b/drivers/gpu/drm/mxsfb/lc= dif_drv.c > index 0f895b8a99d6..1d5508449995 100644 > --- a/drivers/gpu/drm/mxsfb/lcdif_drv.c > +++ b/drivers/gpu/drm/mxsfb/lcdif_drv.c > @@ -16,6 +16,7 @@ > =20 > #include > #include > +#include > #include > #include > #include > @@ -48,6 +49,7 @@ static int lcdif_attach_bridge(struct lcdif_drm_private= *lcdif) > { > struct device *dev =3D lcdif->drm->dev; > struct device_node *ep; > + struct drm_connector *connector; > struct drm_bridge *bridge; > int ret; > =20 > @@ -96,13 +98,23 @@ static int lcdif_attach_bridge(struct lcdif_drm_priva= te *lcdif) > return ret; > } > =20 > - ret =3D drm_bridge_attach(encoder, bridge, NULL, 0); > + ret =3D drm_bridge_attach(encoder, bridge, NULL, DRM_BRIDGE_ATTACH_NO_= CONNECTOR); > if (ret) { > of_node_put(ep); > return dev_err_probe(dev, ret, > "Failed to attach bridge for endpoint%u\n", > of_ep.id); > } > + > + connector =3D drm_bridge_connector_init(lcdif->drm, encoder); > + if (IS_ERR(connector)) { > + ret =3D PTR_ERR(connector); > + of_node_put(ep); > + > + return dev_err_probe(dev, ret, > + "Failed to create bridge connector for endpoint%u\n", > + of_ep.id); > + } > } > =20 > return 0; >=20 > --- > base-commit: f76698bd9a8ca01d3581236082d786e9a6b72bb7 > change-id: 20240624-mxc-lcdif-bridge-attach-60368807b2f9 >=20 > Best regards, >=20 =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/