From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C6849D17143 for ; Mon, 21 Oct 2024 23:11:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 927E910E5C3; Mon, 21 Oct 2024 23:11:41 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="l9De+5jq"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7277D10E5C3 for ; Mon, 21 Oct 2024 23:11:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1729552301; x=1761088301; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=DpKuefItYdggQmEgLz2ly5fQcGVmht9Nqk+/aGlcVPE=; b=l9De+5jqyXXTl9CcGemcQFWBJ+kXcPMgGj+gLJsdaQVbMQhWIIDo3788 fnmExKwo5iRmypP277wvYxSxFVq5zu2gH/DvLXZqIJrFWmR26AFlk77so 9WGRb++Jehx5QLkfrq0GenXS4CNchqcYP4YmmNda443bpwPcqSX8WpIcG 7PZFPsT2+MGgA7SbAnW4Lase4G9PSMDVWkL5ZWRDpwamFh8Qz7aVYUfzU y2bDipSy6sHK5YaKgGXzL001SzrVyZC27E7x1JEV0lv5J29bSk4B86vQ3 Z1/KKU7u9tT2vKWBrneUfvwCGipGxkHjOhoqFTf6xoFLBN/xmBpie6X/k g==; X-CSE-ConnectionGUID: pYyc1XaOQteK4O0qiBwfvw== X-CSE-MsgGUID: bWWtr5v5RFWHQ9Z3hF4vSA== X-IronPort-AV: E=McAfee;i="6700,10204,11232"; a="28495783" X-IronPort-AV: E=Sophos;i="6.11,221,1725346800"; d="scan'208";a="28495783" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2024 16:11:40 -0700 X-CSE-ConnectionGUID: S8l5rP90Qs6a5JVguBVG/A== X-CSE-MsgGUID: SZu74hWxSQu2alBj5AabPQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,221,1725346800"; d="scan'208";a="110504722" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Oct 2024 16:11:40 -0700 Date: Mon, 21 Oct 2024 16:11:39 -0700 Message-ID: <85a5ex2gr8.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Jonathan Cavitt Cc: intel-xe@lists.freedesktop.org, saurabhg.gupta@intel.com, alex.zuo@intel.com, umesh.nerlige.ramappa@intel.com, john.c.harrison@intel.com Subject: Re: [PATCH] drm/xe/xe_guc_ads: save/restore OA registers In-Reply-To: <20241021222401.95833-1-jonathan.cavitt@intel.com> References: <20241021222401.95833-1-jonathan.cavitt@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Mon, 21 Oct 2024 15:24:01 -0700, Jonathan Cavitt wrote: > > Several OA registers were missing from the save restore list for GuC and > could be lost during an engine reset. Add them to the list. > > Suggested-by: Umesh Nerlige Ramappa > Suggested-by: John Harrison > Signed-off-by: Jonathan Cavitt Thanks for chasing this down. Think we should consider this a fix and add: Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2249 And also, maybe, Cc: stable@vger.kernel.org For that we may also need a "Fixes:" tag? Acked-by: Ashutosh Dixit