From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Harish Chegondi <harish.chegondi@intel.com>
Cc: <intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH v11 4/8] drm/xe/eustall: Add support to read() and poll() EU stall data
Date: Tue, 25 Feb 2025 12:55:25 -0800 [thread overview]
Message-ID: <85bjupkama.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <6c8f4edb987cc00ef4f7ab6da90582facc5323b4.1740474556.git.harish.chegondi@intel.com>
On Tue, 25 Feb 2025 01:20:21 -0800, Harish Chegondi wrote:
>
> Implement the EU stall sampling APIs to read() and poll() EU stall data.
> A work function periodically polls the EU stall data buffer write pointer
> registers to look for any new data and caches the write pointer. The read
> function compares the cached read and write pointers and copies any new
> data to the user space.
>
> v11: Used gt->eu_stall->stream_lock instead of stream->buf_lock.
> Removed read and write offsets from trace and added read size.
> Moved workqueue from struct xe_eu_stall_data_stream to
> struct xe_eu_stall_gt.
LGTM now with these changes:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2025-02-25 20:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 9:20 [PATCH v11 0/8] Add support for EU stall sampling Harish Chegondi
2025-02-25 9:20 ` [PATCH v11 1/8] drm/xe/topology: Add a function to find the index of the last enabled DSS in a mask Harish Chegondi
2025-02-25 9:20 ` [PATCH v11 2/8] drm/xe/uapi: Introduce API for EU stall sampling Harish Chegondi
2025-02-25 9:20 ` [PATCH v11 3/8] drm/xe/eustall: Add support to init, enable and disable " Harish Chegondi
2025-02-25 9:20 ` [PATCH v11 4/8] drm/xe/eustall: Add support to read() and poll() EU stall data Harish Chegondi
2025-02-25 20:55 ` Dixit, Ashutosh [this message]
2025-02-25 9:20 ` [PATCH v11 5/8] drm/xe/eustall: Add support to handle dropped " Harish Chegondi
2025-02-25 23:34 ` Dixit, Ashutosh
2025-02-25 9:20 ` [PATCH v11 6/8] drm/xe/eustall: Add EU stall sampling support for Xe2 Harish Chegondi
2025-02-25 9:20 ` [PATCH v11 7/8] drm/xe/uapi: Add a device query to get EU stall sampling information Harish Chegondi
2025-02-25 16:56 ` Dixit, Ashutosh
2025-02-25 9:20 ` [PATCH v11 8/8] drm/xe/eustall: Add workaround 22016596838 which applies to PVC Harish Chegondi
2025-02-25 9:35 ` ✓ CI.Patch_applied: success for Add support for EU stall sampling Patchwork
2025-02-25 9:35 ` ✗ CI.checkpatch: warning " Patchwork
2025-02-25 9:36 ` ✓ CI.KUnit: success " Patchwork
2025-02-25 9:53 ` ✓ CI.Build: " Patchwork
2025-02-25 9:55 ` ✗ CI.Hooks: failure " Patchwork
2025-02-25 9:56 ` ✓ CI.checksparse: success " Patchwork
2025-02-25 10:16 ` ✓ Xe.CI.BAT: " Patchwork
2025-02-25 16:21 ` ✓ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85bjupkama.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=harish.chegondi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.