From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7BCDAC021A0 for ; Wed, 12 Feb 2025 02:12:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32CC610E081; Wed, 12 Feb 2025 02:12:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mWT13bx0"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.18]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6981310E081 for ; Wed, 12 Feb 2025 02:12:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739326372; x=1770862372; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=pH/VY2HvPSbNpJ9EhouW3vhdjI1bJPV9/YRDomds0oo=; b=mWT13bx0mD6d4Pd04KzBFuYpMpl+fgGc/k8fRw/kmKPmqZOK5KNEijjN OEbMZxdkCW0s6qnGroqBhtL/O8IBHqPs+GIQiMhjoZK4QiJt8E1mxHeEr pRP7yZw/DkM+FpoDxv0dbnK665aWj7Cpcu46Qlx6bqlzQmIDSZT5OPI3d mS+Ll/6QSBGhX8ktYvavV0gYEN/cHZJb2OVLb67MCAQgz98aSuPzkr2nn 3xJAOHWZrzR0Mcs8cBMWqu5/JubDXdyXuoswe4GC2W28XIOtjKw26U0Q7 qvVGK/y5dlrXqaV6RrJSJRpOevUjD3YQPB54Aqkulo3FU+0SyEBPUXDZt w==; X-CSE-ConnectionGUID: F+TOz5KWTdemCwKya+NK2g== X-CSE-MsgGUID: pxgg3MwAQzWggW2YUmAoNw== X-IronPort-AV: E=McAfee;i="6700,10204,11342"; a="39203319" X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="39203319" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa112.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 18:12:51 -0800 X-CSE-ConnectionGUID: zKH53kCnSVmajnzHGkfxUA== X-CSE-MsgGUID: jJUoiu7GSM6ShZzHpURrfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,279,1732608000"; d="scan'208";a="112438351" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Feb 2025 18:12:51 -0800 Date: Tue, 11 Feb 2025 18:12:50 -0800 Message-ID: <85bjv73o7x.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Umesh Nerlige Ramappa Cc: Subject: Re: [PATCH] drm/xe/oa: Allow oa_exponent value of 0 In-Reply-To: <20250212010736.1428108-1-umesh.nerlige.ramappa@intel.com> References: <20250212010736.1428108-1-umesh.nerlige.ramappa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 11 Feb 2025 17:07:36 -0800, Umesh Nerlige Ramappa wrote: > Hi Umesh, > OA exponent value of 0 is a valid value for periodic reports. Allow user > to pass 0 for the OA sampling interval since it gets converted to 2 gt > clock ticks. > > Signed-off-by: Umesh Nerlige Ramappa > --- > drivers/gpu/drm/xe/xe_oa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c > index a692dffcb638..268403b9b527 100644 > --- a/drivers/gpu/drm/xe/xe_oa.c > +++ b/drivers/gpu/drm/xe/xe_oa.c > @@ -2025,7 +2025,7 @@ int xe_oa_stream_open_ioctl(struct drm_device *dev, u64 data, struct drm_file *f > goto err_exec_q; > } > > - if (param.period_exponent > 0) { > + if (param.period_exponent >= 0) { > u64 oa_period, oa_freq_hz; > > /* Requesting samples from OAG buffer is a privileged operation */ > -- > 2.34.1 > I think this also would need to be changed: static int xe_oa_stream_init(struct xe_oa_stream *stream, struct xe_oa_open_param *param) { ... stream->periodic = param->period_exponent > 0; Ashutosh