From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 86D0CD41C3A for ; Thu, 14 Nov 2024 04:33:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 50C8710E794; Thu, 14 Nov 2024 04:33:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HUCDCejS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 40B0E10E794 for ; Thu, 14 Nov 2024 04:33:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1731558833; x=1763094833; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=emQrX91EVbMDA50IiCf7LHwO157Ht+EGb5GVlBjz1yE=; b=HUCDCejSn8X8L4ThlzLD3ikUCkI91DoQj3c0DEo3RKJKTnO+2q2ZAhMR MCaoQzBXSyjx4hWnStd/zQ83TK7WEG0xReq7q8klVqlmJOuB5IrWi5+wg sebmF6qc721o6k2XYdXUQsJseHih6eAurc3g8B81oOOVSe9mjkX3NXYmf XgBtXSxaf7ca2C1qiKm3mADDMZ8/XRFWMEdEkl1SRwejGSKM/VQW8D+G4 s6Jh5mIWB+pNEDAXdZDCrfZG+iA0EnIWEpX+qUeb6bxC1sTCnEzMMwjC2 D2hL4K1paFEm+oOpEFMed9PTO5niq/d7I6dC19tQpld3rgyxHghCcYC5V g==; X-CSE-ConnectionGUID: WTQdM9VfRduAWNxwCrl8Fw== X-CSE-MsgGUID: 1OdwP0lySkWGpfgslUnlVA== X-IronPort-AV: E=McAfee;i="6700,10204,11255"; a="42105071" X-IronPort-AV: E=Sophos;i="6.12,153,1728975600"; d="scan'208";a="42105071" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2024 20:33:53 -0800 X-CSE-ConnectionGUID: qFRabU8nRDCEuH+aHyKL3Q== X-CSE-MsgGUID: +W3GA734QCmssrEuZvrbZQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,153,1728975600"; d="scan'208";a="88475524" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Nov 2024 20:33:53 -0800 Date: Wed, 13 Nov 2024 20:33:52 -0800 Message-ID: <85bjyixwlr.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lucas De Marchi Cc: Vinay Belgaumkar , , Aravind Iddamsetty , Bommu Krishnaiah , Riana Tauro , "Rodrigo\ Vivi" Subject: Re: [PATCH v6 1/3] drm/xe/pmu: Enable PMU interface In-Reply-To: References: <20241113174242.24787-1-vinay.belgaumkar@intel.com> <20241113174242.24787-2-vinay.belgaumkar@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 13 Nov 2024 19:16:55 -0800, Lucas De Marchi wrote: > > > diff --git a/drivers/gpu/drm/xe/xe_device_types.h b/drivers/gpu/drm/xe/xe_device_types.h > > index bccca63c8a48..0cb8d650135a 100644 > > --- a/drivers/gpu/drm/xe/xe_device_types.h > > +++ b/drivers/gpu/drm/xe/xe_device_types.h > > @@ -18,6 +18,7 @@ > > #include "xe_memirq_types.h" > > #include "xe_oa.h" > > #include "xe_platform_types.h" > > +#include "xe_pmu.h" > > you will need a xe_pmu_types.h where you only define the types. > See the other lines that serve as good citizens, don't look at xe_oa.h What's wrong with xe_oa.h :) There's an xe_oa_types.h!