From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Jonathan Cavitt <jonathan.cavitt@intel.com>
Cc: intel-xe@lists.freedesktop.org, saurabhg.gupta@intel.com,
alex.zuo@intel.com, umesh.nerlige.ramappa@intel.com,
john.c.harrison@intel.com
Subject: Re: [PATCH v2] drm/xe/xe_guc_ads: save/restore OA registers
Date: Wed, 23 Oct 2024 12:31:16 -0700 [thread overview]
Message-ID: <85bjzavcor.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20241022141054.5311-1-jonathan.cavitt@intel.com>
On Tue, 22 Oct 2024 07:10:54 -0700, Jonathan Cavitt wrote:
>
> Several OA registers and allowlist registers were missing from the
> save/restore list for GuC and could be lost during an engine reset. Add
> them to the list.
>
> v2:
> - Fix commit message (Umesh)
> - Add missing closes (Ashutosh)
>
> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2249
> Suggested-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
> Suggested-by: John Harrison <john.c.harrison@intel.com>
> Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
> Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> Reviewed-by: Umesh Nerlige Ramappa <umesh.nerlige.ramappa@intel.com>
How about also adding to this:
Fixes: dd08ebf6c352 ("drm/xe: Introduce a new DRM driver for Intel GPUs")
Cc: stable@vger.kernel.org
Otherwise if anyone tries OA on 6.11 (when it appeared) might hit this
issue and start filing bugs etc. So the simplest I think is to add the
above now itself.
Otoh, 6.12 will probably be a LTS kernel and this patch will be there...
prev parent reply other threads:[~2024-10-23 19:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-22 14:10 [PATCH v2] drm/xe/xe_guc_ads: save/restore OA registers Jonathan Cavitt
2024-10-22 14:16 ` ✓ CI.Patch_applied: success for drm/xe/xe_guc_ads: save/restore OA registers (rev2) Patchwork
2024-10-22 14:16 ` ✓ CI.checkpatch: " Patchwork
2024-10-22 14:17 ` ✓ CI.KUnit: " Patchwork
2024-10-22 14:29 ` ✓ CI.Build: " Patchwork
2024-10-22 14:31 ` ✓ CI.Hooks: " Patchwork
2024-10-22 14:32 ` ✓ CI.checksparse: " Patchwork
2024-10-22 14:55 ` ✗ CI.BAT: failure " Patchwork
2024-10-22 16:15 ` ✗ CI.FULL: " Patchwork
2024-10-23 19:31 ` Dixit, Ashutosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85bjzavcor.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=alex.zuo@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=john.c.harrison@intel.com \
--cc=jonathan.cavitt@intel.com \
--cc=saurabhg.gupta@intel.com \
--cc=umesh.nerlige.ramappa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.