All of lore.kernel.org
 help / color / mirror / Atom feed
From: "René Rebe" <rene@exactcode.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] QXL: always show default cursor, even for unsupported chunks
Date: Fri, 18 Aug 2017 15:02:04 +0200	[thread overview]
Message-ID: <85cdeb9f-a6ea-5530-edcd-10ed3853026f@exactcode.com> (raw)

Hi,

I was testing a Windows 10 guest with HiDPI scaling which

actually made the cursor disappear and only multiple chunks

warnings being printed.

When the cursor is using currently unsupported multiple chunks, the
builtin-left cursor is better than none.

PS: if TB damages the white-space just let me know, only recently 
started using it, ...

   - René Rebe <rene@exactcode.de>

diff -u -ur qemu-2.10.0-rc3/hw/display/qxl-render.c 
qemu-2.10.0-rc3-fixed/hw/display/qxl-render.c
--- qemu-2.10.0-rc3/hw/display/qxl-render.c    2017-08-15 
20:39:41.000000000 +0200
+++ qemu-2.10.0-rc3-fixed/hw/display/qxl-render.c    2017-08-17 
13:42:37.108953910 +0200
@@ -270,9 +270,10 @@
          }
          if (cursor->chunk.data_size != cursor->data_size) {
              fprintf(stderr, "%s: multiple chunks\n", __FUNCTION__);
-            return 1;
+            c = NULL; /* fall back to built-in left cursor */
+        } else {
+            c = qxl_cursor(qxl, cursor);
          }
-        c = qxl_cursor(qxl, cursor);
          if (c == NULL) {
              c = cursor_builtin_left_ptr();
          }

             reply	other threads:[~2017-08-18 13:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-18 13:02 René Rebe [this message]
2017-08-18 14:37 ` [Qemu-devel] [PATCH] QXL: always show default cursor, even for unsupported chunks Dr. David Alan Gilbert
2017-08-18 14:55   ` Eric Blake
2017-08-23 14:36   ` Gerd Hoffmann
2017-08-23 14:58     ` René Rebe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85cdeb9f-a6ea-5530-edcd-10ed3853026f@exactcode.com \
    --to=rene@exactcode.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.