From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C5596C531C9 for ; Fri, 24 Jul 2026 21:15:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8249C10E1B8; Fri, 24 Jul 2026 21:15:50 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="mU01n+t1"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5675A10E1B8 for ; Fri, 24 Jul 2026 21:15:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1784927749; x=1816463749; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=U44y0ZlyVxXFF+DkMeLcA7S7I0/x1Y/8InjuFnfJfQk=; b=mU01n+t1EbYpYyGoWI58cWOj3/GFUwv9Ou9Idn/H3JqWbjNeuPKyRic9 Y2I8fwIj/IePCPoixamtez1IfHAipS/GzYbhSYlbiYqN14xG9iUdoxATN F/vU/7Qvu/R09jGiG9/3w/QUJ2Gw26pCdbJPoDpagkp3xiZLAvz8aQbux gmk7x559EMWCclhdHHmwe34w/sFYXiwDBbP+1I9EvRA0ClxWOMq3p1hPv ovbbk+nqXywNxPZnXcWlgYcUS08LE4MBc/i3H/0IStQ6da3OvD/SVex0V Iwt/nxAx7+2BgE0GzdtDr0/VGegzDHZ9LY8SrV4WG3NxJSYsn9vD5opbb w==; X-CSE-ConnectionGUID: /Tba0N+2QFuf6j1us7ldoA== X-CSE-MsgGUID: 8Rt0+SKHRW2UYuwT01/dhQ== X-IronPort-AV: E=McAfee;i="6800,10657,11855"; a="96264016" X-IronPort-AV: E=Sophos;i="6.25,183,1779174000"; d="scan'208";a="96264016" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2026 14:15:48 -0700 X-CSE-ConnectionGUID: TW/2/3VgT0Ow50RaRuEVSw== X-CSE-MsgGUID: qRT1Xtm2RkWTxRyJTA+I+w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.25,183,1779174000"; d="scan'208";a="255454679" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.88.27.185]) by fmviesa007-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Jul 2026 14:15:48 -0700 Date: Fri, 24 Jul 2026 14:15:48 -0700 Message-ID: <85cxwcw0l7.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: intel-xe@lists.freedesktop.org Cc: Gustavo Sousa , Matt Roper Subject: Re: [PATCH 1/2] drm/xe/mcr: Take vcs1/vecs1 into account for first media slice In-Reply-To: <20260724201129.2814030-2-ashutosh.dixit@intel.com> References: <20260724201129.2814030-1-ashutosh.dixit@intel.com> <20260724201129.2814030-2-ashutosh.dixit@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Fri, 24 Jul 2026 13:11:28 -0700, Ashutosh Dixit wrote: > > vcs1 and vecs1 may also be present on the first media slice, so take > vcs1/vecs1 also into account when determining if the first media slice is > absent. > > Bspec: 77977 > > Cc: Gustavo Sousa > Cc: Matt Roper > Signed-off-by: Ashutosh Dixit > --- > drivers/gpu/drm/xe/xe_gt_mcr.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/xe/xe_gt_mcr.c b/drivers/gpu/drm/xe/xe_gt_mcr.c > index 9799ffadf85d2..d069d141b54d6 100644 > --- a/drivers/gpu/drm/xe/xe_gt_mcr.c > +++ b/drivers/gpu/drm/xe/xe_gt_mcr.c > @@ -454,9 +454,10 @@ static void init_steering_oaddrm(struct xe_gt *gt) > { > /* > * First instance is only terminated if the entire first media slice > - * is absent (i.e., no VCS0 or VECS0). > + * is absent (i.e., no VCS0, VCS1, VECS0 or VECS1). > */ > - if (gt->info.engine_mask & (XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VECS0)) > + if (gt->info.engine_mask & (XE_HW_ENGINE_VCS0 | XE_HW_ENGINE_VCS1 | > + XE_HW_ENGINE_VECS0 | XE_HW_ENGINE_VECS0)) Sorry, the last term in the above line should be XE_HW_ENGINE_VECS1. I will fix this up in v2. > gt->steering[OADDRM].group_target = 0; > else > gt->steering[OADDRM].group_target = 1; > -- > 2.54.0 >