From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5147FC432C0 for ; Wed, 20 Nov 2019 21:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1AD2D20855 for ; Wed, 20 Nov 2019 21:22:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=mojatatu-com.20150623.gappssmtp.com header.i=@mojatatu-com.20150623.gappssmtp.com header.b="kVACOyvW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725904AbfKTVWS (ORCPT ); Wed, 20 Nov 2019 16:22:18 -0500 Received: from mail-qk1-f196.google.com ([209.85.222.196]:36975 "EHLO mail-qk1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725819AbfKTVWS (ORCPT ); Wed, 20 Nov 2019 16:22:18 -0500 Received: by mail-qk1-f196.google.com with SMTP id e187so1200858qkf.4 for ; Wed, 20 Nov 2019 13:22:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mojatatu-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=dNN3QSPg5qZsdUba3YVMXeGbFwn5OLVwTziw/+HVaOc=; b=kVACOyvWgooWFBICKf+2sgoQ6UxYRcC/x/SmQcmq0XcawVcVh8ASWIlPtWcRjsbAJD 84qi1/1CsTxJkPXOjAC5x+m+SoZ5VHPsVVCsotvBVmRfPGgM6Jz9cRPj4hlXkhN0Wbjf IEEFLZaNED7//bcRqFoUgipCXGIzZYiKneVDrps/9vD//2/WfeTqWreyKMYyS8xa/FkS nwWXkEadCpzBmwsxA6au67VC4t/5GDMU2dx2DarTzJNCwz7GThIu7kyefdBnRBcdecHY 1vtUJXZhtxZSvoTUM+Dph57WmEMvowy2wRfN0PbqdtClzqepV1DGrzZ3QXjRIxJrxEUw c+Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=dNN3QSPg5qZsdUba3YVMXeGbFwn5OLVwTziw/+HVaOc=; b=rKXUFKXHAd/z9GmWp5SduvYSEEIHAY34uaRGY1nJX84AninSpdW3KlZeYu5bI+QGyL Zdg7yPBsRWWMvZjTk5t6M3UU/u6MeqquwN63yH9Bq5x8whSLBhtfp6POUm87uwpFUhPL wVD8bkZj8Zvhr4QzdqrzW8wLw/pnpIlsKqJYB+gsAQCMomRilPjzVhqsEh8HrpGOJeNJ BbLuLdqmRfXmV06d6PUzhichEWSCcxmjxMaAy5BESKs/9pbKg7aR2VB0e1HDiQb18tar XxEH+ulgnsETXn/+F8VwjEsxRSs81dVXXbhFxK5SOjr2fUu+fJl/7PwkGNKp9K0i9AKQ 1akw== X-Gm-Message-State: APjAAAUeC/3NqvbTg1GeVr/FLBBKm3Ojas3cCb/BsSnwg+L1ytt04l11 SyC2I9dTwA4Ig/W9Hr14ZoB6mA== X-Google-Smtp-Source: APXvYqz3lQPEjo2AUYvAhq5xuyG1oX3hKcfaYkMVrh8HJGeSH2GqFYUnyfOhXVslgVbZT8ZbNjgn1w== X-Received: by 2002:a37:4906:: with SMTP id w6mr4733269qka.82.1574284937039; Wed, 20 Nov 2019 13:22:17 -0800 (PST) Received: from sevai (69-196-152-194.dsl.teksavvy.com. [69.196.152.194]) by smtp.gmail.com with ESMTPSA id n185sm289039qkd.32.2019.11.20.13.22.15 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 20 Nov 2019 13:22:16 -0800 (PST) From: Roman Mashak To: Petr Machata Cc: "netdev\@vger.kernel.org" , Ido Schimmel , Roopa Prabhu Subject: Re: [RFC PATCH 10/10] selftests: qdiscs: Add test coverage for ETS Qdisc References: <4c364de6add3e615f1675ddb4d2911491a65bd8a.1574253236.git.petrm@mellanox.com> <85h82ybmun.fsf@mojatatu.com> <87o8x6d05t.fsf@mellanox.com> Date: Wed, 20 Nov 2019 16:22:15 -0500 In-Reply-To: <87o8x6d05t.fsf@mellanox.com> (Petr Machata's message of "Wed, 20 Nov 2019 15:42:40 +0000") Message-ID: <85d0dmb5vc.fsf@mojatatu.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Petr Machata writes: > Roman Mashak writes: > >> Petr Machata writes: >> >>> Add TDC coverage for the new ETS Qdisc. >>> >> >> It would be good to have tests for upper bound limits of qdisc >> parameters. > > All right. I can think of "bands 16", and then "quantum $(((1 << 32) - > 1))", but I'm not sure the latter is very useful. Did you have anything > else in mind? I think, any test that would validate the user's input of parameters would suffice, e.g. min/max acceptable values, range of values and such.