All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: <nishit.sharma@intel.com>
Cc: <igt-dev@lists.freedesktop.org>, <pravalika.gurram@intel.com>,
	<himal.prasad.ghimiray@intel.com>, <kamil.konieczny@intel.com>
Subject: Re: [PATCH v8 1/1] tests/intel/xe_exec_system_allocator: Add pat-index-madvise
Date: Wed, 17 Sep 2025 12:40:30 -0700	[thread overview]
Message-ID: <85ecs4kgup.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250917171941.3025392-2-nishit.sharma@intel.com>

On Wed, 17 Sep 2025 10:19:41 -0700, <nishit.sharma@intel.com> wrote:
>
> +	for (const struct section *s = intel_get_pat_idx_functions; s->name; s++) {
> +		igt_subtest_f("pat-index-%s", s->name) {
> +			if ((strstr(s->name, "madvise-pat-idx-wt-") ||
> +			     strstr(s->name, "madvise-pat-idx-uc-comp-")) &&
> +			     !xe_has_vram(fd)) {
> +				igt_skip("Skipping compression-related PAT index\n");
> +			}
> +			xe_for_each_engine(fd, hwe)
> +				test_exec(fd, hwe, 1, 1, SZ_4M, 0, 0, NULL, NULL, s->flags, s->fn);

I think it is also possible to add a 'igt_require(xe_has_vram(fd))' in
intel_get_pat_idx_wt() and intel_get_pat_idx_uc_comp(). But anyway, it's ok
as is too, so this is:

Acked-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

>		}
>	}
>
> --
> 2.43.0
>

  reply	other threads:[~2025-09-17 19:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-17 17:19 [PATCH v8 0/1] Add pat-index-madvise nishit.sharma
2025-09-17 17:19 ` [PATCH v8 1/1] tests/intel/xe_exec_system_allocator: " nishit.sharma
2025-09-17 19:40   ` Dixit, Ashutosh [this message]
2025-09-18 13:59     ` Kamil Konieczny
2025-09-19  9:08       ` Gurram, Pravalika
2025-09-19  9:33   ` Kamil Konieczny
2025-09-18  5:42 ` ✓ Xe.CI.BAT: success for " Patchwork
2025-09-18  5:52 ` ✓ i915.CI.BAT: " Patchwork
2025-09-18 12:37 ` ✓ Xe.CI.Full: " Patchwork
2025-09-18 12:47 ` ✓ i915.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85ecs4kgup.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=kamil.konieczny@intel.com \
    --cc=nishit.sharma@intel.com \
    --cc=pravalika.gurram@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.