From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@vger.kernel.org>
Received: from mail-io0-f193.google.com ([209.85.223.193]:34100 "EHLO
        mail-io0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751977AbeCEPqF (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 5 Mar 2018 10:46:05 -0500
Received: by mail-io0-f193.google.com with SMTP id e7so18468138ioj.1
        for <netdev@vger.kernel.org>; Mon, 05 Mar 2018 07:46:05 -0800 (PST)
From: Roman Mashak <mrv@mojatatu.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, kernel@mojatatu.com, jhs@mojatatu.com,
        jiri@resnulli.us, xiyou.wangcong@gmail.com
Subject: Re: [PATCH net-next 2/5] net sched actions: add new tc_action_ops callback
References: <1520028103-14878-1-git-send-email-mrv@mojatatu.com>
        <1520028103-14878-3-git-send-email-mrv@mojatatu.com>
        <20180305.100048.1284648153742420410.davem@davemloft.net>
Date: Mon, 05 Mar 2018 10:46:04 -0500
In-Reply-To: <20180305.100048.1284648153742420410.davem@davemloft.net> (David
        Miller's message of "Mon, 05 Mar 2018 10:00:48 -0500 (EST)")
Message-ID: <85fu5epltv.fsf@sevai.TCC.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

David Miller <davem@davemloft.net> writes:

> From: Roman Mashak <mrv@mojatatu.com>
> Date: Fri,  2 Mar 2018 17:01:40 -0500
>
>> diff --git a/net/sched/act_api.c b/net/sched/act_api.c
>> index acac92a..6f3307f 100644
>> --- a/net/sched/act_api.c
>> +++ b/net/sched/act_api.c
>> @@ -136,6 +136,14 @@ static size_t tcf_action_full_attrs_size(size_t sz)
>>  		+ sz;
>>  }
>>  
>> +static size_t tcf_action_fill_size(const struct tc_action *act)
>> +{
>> +	if (act->ops->get_fill_size)
>> +		return act->ops->get_fill_size(act) +
>> +			tcf_action_shared_attrs_size(act);
>> +	return 0;
>> +}
>> +
>
> Again, a static functions with no users generates compiler warnings.

Thanks, will fix in v2.