From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D2D07C35249 for ; Wed, 5 Feb 2020 04:21:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A1EFB21741 for ; Wed, 5 Feb 2020 04:21:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727911AbgBEEVm (ORCPT ); Tue, 4 Feb 2020 23:21:42 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47498 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727846AbgBEEVm (ORCPT ); Tue, 4 Feb 2020 23:21:42 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 694AB29298E From: Gabriel Krisman Bertazi To: Daniel Rosenberg Cc: "Theodore Ts'o" , linux-ext4@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, Alexander Viro , Richard Weinberger , linux-mtd@lists.infradead.org, Andreas Dilger , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v6 1/5] unicode: Add standard casefolded d_ops Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> <85sgjsxx2g.fsf@collabora.com> Date: Tue, 04 Feb 2020 23:21:33 -0500 In-Reply-To: (Daniel Rosenberg's message of "Tue, 4 Feb 2020 19:05:02 -0800") Message-ID: <85h8051x6a.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-ext4-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-ext4@vger.kernel.org Daniel Rosenberg writes: > On Sun, Feb 2, 2020 at 5:46 PM Gabriel Krisman Bertazi > wrote: >> >> >> I don't think fs/unicode is the right place for these very specific >> filesystem functions, just because they happen to use unicode. It is an >> encoding library, it doesn't care about dentries, nor should know how to >> handle them. It exposes a simple api to manipulate and convert utf8 strings. >> >> I saw change was after the desire to not have these functions polluting >> the VFS hot path, but that has nothing to do with placing them here. >> >> Would libfs be better? or a casefolding library in fs/casefold.c? >> >> >> -- >> Gabriel Krisman Bertazi > > The hash function needs access to utf8ncursor, but apart from that, > libfs would make sense. utf8ncursor is the only reason I have them > here. How do you feel about exposing utf8cursor or something similar? Hi, It was designed to be an internal thing, but I'm ok with exposing it. -- Gabriel Krisman Bertazi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BCB3C35249 for ; Wed, 5 Feb 2020 04:21:57 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE1FA21741 for ; Wed, 5 Feb 2020 04:21:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="UBSS4w+Z"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="fHxZa6Tg" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE1FA21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-2.v29.lw.sourceforge.com) by sfs-ml-2.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1izCCK-0008Dw-7t; Wed, 05 Feb 2020 04:21:56 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-2.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1izCCI-0008Do-Rj for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Feb 2020 04:21:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Type:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=fqzN6b452rdZZaRyKiGrVh5MWdZs8ZehY7iXYXh+iBM=; b=UBSS4w+ZAoWp9EOPkcjcbNb0BU T68rnX5e77jr/H7KIuwhl6DwH6vF+NZWA26jgCyeRSa+LgNMpiGMzbSW2yWbZUZyCEcl1k9IQvRG9 uzVsT/j1JveJH4o76LlFXLjXj4jyKbOJ+A69xTI7GU5/Uwn0u2p2ucl3iHRlkQXDwVkg=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject: Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=fqzN6b452rdZZaRyKiGrVh5MWdZs8ZehY7iXYXh+iBM=; b=fHxZa6TgOETX8QIzAA/+pBVGOH bROP39bKXsF/UaU4bUtwlJW4xuwaQI5Z13nXAYZt86uJPAFwT2FB0Of0txL9DfnXwdVlSrDTchVoK BvFusV83eXmrpAFqP5tXneWqVjXBPSK1FJjZM84BF3E0MyZbXGhWqpT9zlVM19QYKw5Y=; Received: from bhuna.collabora.co.uk ([46.235.227.227]) by sfi-mx-4.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.2) id 1izCCH-00AZyO-8c for linux-f2fs-devel@lists.sourceforge.net; Wed, 05 Feb 2020 04:21:54 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 694AB29298E From: Gabriel Krisman Bertazi To: Daniel Rosenberg Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> <85sgjsxx2g.fsf@collabora.com> Date: Tue, 04 Feb 2020 23:21:33 -0500 In-Reply-To: (Daniel Rosenberg's message of "Tue, 4 Feb 2020 19:05:02 -0800") Message-ID: <85h8051x6a.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-Headers-End: 1izCCH-00AZyO-8c Subject: Re: [f2fs-dev] [PATCH v6 1/5] unicode: Add standard casefolded d_ops X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net Daniel Rosenberg writes: > On Sun, Feb 2, 2020 at 5:46 PM Gabriel Krisman Bertazi > wrote: >> >> >> I don't think fs/unicode is the right place for these very specific >> filesystem functions, just because they happen to use unicode. It is an >> encoding library, it doesn't care about dentries, nor should know how to >> handle them. It exposes a simple api to manipulate and convert utf8 strings. >> >> I saw change was after the desire to not have these functions polluting >> the VFS hot path, but that has nothing to do with placing them here. >> >> Would libfs be better? or a casefolding library in fs/casefold.c? >> >> >> -- >> Gabriel Krisman Bertazi > > The hash function needs access to utf8ncursor, but apart from that, > libfs would make sense. utf8ncursor is the only reason I have them > here. How do you feel about exposing utf8cursor or something similar? Hi, It was designed to be an internal thing, but I'm ok with exposing it. -- Gabriel Krisman Bertazi _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B09CC35249 for ; Wed, 5 Feb 2020 04:22:08 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2B5A21741 for ; Wed, 5 Feb 2020 04:22:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="kygdiVra" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2B5A21741 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:In-Reply-To: Date:References:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GXpARyMEPrUPP/L1ZyerkL8BNa+Noun8A/bQ30ujeV4=; b=kygdiVramhaSzZ +oPbR9a4t51LfxLK4cS/H9+a5HVGY5W1c6cwflShEpABD57+XGI3MSX0nOYHW0Iai7HohUJECEZBI 60Ypg4klGL1IH6KDRzVUJMkYTh/AK2buLT362/Lu281ppDyY6+n+QCdfJIaPxMGVUUPU4Wyfd/n4x cURevppKtdXXTBWUIDdc8lCZPDooBYzwOHe3R4/QIQ+gOuWcGr3JrHh3eTYmdjjzunWJ9qJjdJhKj lDQHTB86amob+EuWhxygyvv/hSRkoOgWaVsBuPuUqMQ1d5Pt/lJNLhIpWNHYF3/MhcJFLpye2fJTI pM4+ALKdVjBb3o3PO5pQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izCCB-00060S-ML; Wed, 05 Feb 2020 04:21:47 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izCC8-0005zA-F1 for linux-mtd@lists.infradead.org; Wed, 05 Feb 2020 04:21:45 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 694AB29298E From: Gabriel Krisman Bertazi To: Daniel Rosenberg Subject: Re: [PATCH v6 1/5] unicode: Add standard casefolded d_ops Organization: Collabora References: <20200128230328.183524-1-drosen@google.com> <20200128230328.183524-2-drosen@google.com> <85sgjsxx2g.fsf@collabora.com> Date: Tue, 04 Feb 2020 23:21:33 -0500 In-Reply-To: (Daniel Rosenberg's message of "Tue, 4 Feb 2020 19:05:02 -0800") Message-ID: <85h8051x6a.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200204_202144_635077_AA4149DD X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Theodore Ts'o , Jonathan Corbet , Richard Weinberger , Andreas Dilger , Chao Yu , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, Eric Biggers , linux-fscrypt@vger.kernel.org, linux-mtd@lists.infradead.org, Alexander Viro , linux-fsdevel@vger.kernel.org, Jaegeuk Kim , linux-ext4@vger.kernel.org, kernel-team@android.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org Daniel Rosenberg writes: > On Sun, Feb 2, 2020 at 5:46 PM Gabriel Krisman Bertazi > wrote: >> >> >> I don't think fs/unicode is the right place for these very specific >> filesystem functions, just because they happen to use unicode. It is an >> encoding library, it doesn't care about dentries, nor should know how to >> handle them. It exposes a simple api to manipulate and convert utf8 strings. >> >> I saw change was after the desire to not have these functions polluting >> the VFS hot path, but that has nothing to do with placing them here. >> >> Would libfs be better? or a casefolding library in fs/casefold.c? >> >> >> -- >> Gabriel Krisman Bertazi > > The hash function needs access to utf8ncursor, but apart from that, > libfs would make sense. utf8ncursor is the only reason I have them > here. How do you feel about exposing utf8cursor or something similar? Hi, It was designed to be an internal thing, but I'm ok with exposing it. -- Gabriel Krisman Bertazi ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/