Re: [PATCH] drm/xe: Use correct function pointer type

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 19 Mar 2024 10:49:19 -0700, Niranjana Vishwanathapura wrote:
>
> Use xe_exec_queue_user_extension_fn type for
> exec_queue_user_extension_funcs.`
>
> Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_exec_queue.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
> index 2016c1af9633..dd10188e8f4d 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -388,7 +388,7 @@ typedef int (*xe_exec_queue_user_extension_fn)(struct xe_device *xe,
>					       struct xe_exec_queue *q,
>					       u64 extension);
>
> -static const xe_exec_queue_set_property_fn exec_queue_user_extension_funcs[] = {
> +static const xe_exec_queue_user_extension_fn exec_queue_user_extension_funcs[] = {
>	[DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY] = exec_queue_user_ext_set_property,

The change is correct, though the types xe_exec_queue_set_property_fn and
xe_exec_queue_user_extension_fn are exactly the same (one has 'u64 value'
and the other 'u64 extension'). So it may even be possible to eliminte one
of them. That is why the compiler does not complain.

Anyway:

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>



>  };
>
> --
> 2.43.0
>