From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30CFFCD11C2 for ; Wed, 10 Apr 2024 06:07:02 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 87B6D113151; Wed, 10 Apr 2024 06:07:01 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="JiUpMIFV"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by gabe.freedesktop.org (Postfix) with ESMTPS id A4D5A113151 for ; Wed, 10 Apr 2024 06:06:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712729219; x=1744265219; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=PeMCtkLgm2agxSd/r066X2vX6fDysOUdU2UjIMq5/UE=; b=JiUpMIFVVcaYeyckb0HXXYe3hCz3fYspgX+Azj6Qapp1R6FvHgriLFOS c6Osf8gcgefvY6qManXUo3DDu6eKjDUhKCEGhXFXzVAAGP/IcfQuuKkEN mvkTWvkGA8GWuR4sqOOmkUjYK/0FQ4UwwvVuYeI/PMVPje+J6uddwLXcR 4YRqsprfPamH6HUPxGFW3ReR5Qf3lebtefOG0seaYyUOO5ha2qap9noz5 LyGVvxOSQa6k+KpSAZKZ5ye0exTW1lIUKmHFcpBjSlzqB2mPcYx+KR9IH ulZwePoByUH0IAtsctD0BsJXZVsv1H72i8bHd4SotI13eNKIvjPqSK+Sl Q==; X-CSE-ConnectionGUID: dPb569r7QTy5hVHWJvfaVA== X-CSE-MsgGUID: MIojT78+TJqNQagXzu3aSA== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="8645569" X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="8645569" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 23:06:59 -0700 X-CSE-ConnectionGUID: 81zzXvWHSEGhTryMeDtMHQ== X-CSE-MsgGUID: /O04KMplQPOD2+Tdu/fkqQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,190,1708416000"; d="scan'208";a="25242669" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Apr 2024 23:06:59 -0700 Date: Tue, 09 Apr 2024 23:06:58 -0700 Message-ID: <85seztkayl.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: "Nilawar, Badal" Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/i915: Don't enable hwmon for selftests In-Reply-To: <1e16a3a8-81e2-4214-a07c-74922627f232@intel.com> References: <20240410045832.149779-1-ashutosh.dixit@intel.com> <1e16a3a8-81e2-4214-a07c-74922627f232@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, 09 Apr 2024 22:17:38 -0700, Nilawar, Badal wrote: > > > +#if IS_ENABLED(CONFIG_DRM_I915_SELFTEST) > > + return i915_selftest.live || i915_selftest.perf || i915_selftest.mock; > > +#else > > + return false; > > +#endif > > +} > I think you moved this function here as this is only used in > i915_hwmon.c. In case if somewhere else this function is needed then I > suggest to move this function to i915_selftest.h as inline function. Thanks, done in v3.