From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 08719C77B7F for ; Fri, 27 Jun 2025 23:35:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 89FDE10E0E0; Fri, 27 Jun 2025 23:35:37 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="k6DkTxTp"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 51ABD10E0E0 for ; Fri, 27 Jun 2025 23:35:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1751067337; x=1782603337; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=Tb4US5yeuQsBe7sT3MJyVZpu7r6ZAIhqzc8ET3wcu5k=; b=k6DkTxTpTfaFEi3VG0Y6kFQbwOj8Rq6RNbEihHLN5nl36qTMwOczv+QH ateUJmSDhwr9XOESobPK4DxEGvb9MaPX6MBX0OXzyg0T3S5dYLT1QrOc8 HEk4QFvnFJQKMMU6wtGxAShZh+smizUhF8e+RXsQZHEo7gVx5WHWmik4m UVNQXo/yzrtiliXVhFE35wVQ8RfvU8S36+jK5emahUkAheHCltTnAfMhz T8pSbEk48XueXqkEc1NP3TTGa5CLF1AqMjhWDAGNT0+ioC3yon20j/Js2 dXVCqt5gS+2fcSY+jA6Ef1ykCix+l81ms3iIysNulsphol798z0QMhfjt Q==; X-CSE-ConnectionGUID: mWMLMhqJTV6W3sJazHr0zQ== X-CSE-MsgGUID: fM3LVTqFRkGALA3+ho2KOg== X-IronPort-AV: E=McAfee;i="6800,10657,11477"; a="53109938" X-IronPort-AV: E=Sophos;i="6.16,271,1744095600"; d="scan'208";a="53109938" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2025 16:35:30 -0700 X-CSE-ConnectionGUID: GYIyi1ERT0WD/Lndbtetxw== X-CSE-MsgGUID: WExCnfBbTiKMDePWxZwcyA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.16,271,1744095600"; d="scan'208";a="152318458" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 27 Jun 2025 16:35:29 -0700 Date: Fri, 27 Jun 2025 16:35:29 -0700 Message-ID: <85wm8wkbb2.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH i-g-t 1/1] tests/intel/xe_eu_stall: Use default sampling rate from the query IOCTL data In-Reply-To: <766c5f4f8604f752be1894aa9d17f9c16b84d4df.1751057370.git.harish.chegondi@intel.com> References: <766c5f4f8604f752be1894aa9d17f9c16b84d4df.1751057370.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: igt-dev@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development mailing list for IGT GPU Tools List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" On Fri, 27 Jun 2025 13:50:50 -0700, Harish Chegondi wrote: > > EU stall query IOCTL returns the supported sampling rates. If the user > doesn't pass a sampling rate, use a mid sampling rate from those > returned from the query IOCTL. Reviewed-by: Ashutosh Dixit > > Cc: Ashutosh Dixit > Signed-off-by: Harish Chegondi > --- > tests/intel/xe_eu_stall.c | 20 +++++++++++--------- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a/tests/intel/xe_eu_stall.c b/tests/intel/xe_eu_stall.c > index c496e654b..88202488c 100644 > --- a/tests/intel/xe_eu_stall.c > +++ b/tests/intel/xe_eu_stall.c > @@ -54,7 +54,6 @@ > #define MAX_XECORES 64 > #define NUM_ITERS_GPGPU_FILL 100 > #define DEFAULT_NUM_REPORTS 1 > -#define DEFAULT_SAMPLE_RATE (251 * 4) > #define DEFAULT_USER_BUF_SIZE (64 * 512 * 1024) > > #define WIDTH 64 > @@ -346,17 +345,17 @@ static void test_invalid_arguments(int drm_fd, uint8_t gt_id, uint32_t rate, uin > > static void test_invalid_gt_id(int fd) > { > - test_invalid_arguments(fd, 255, DEFAULT_SAMPLE_RATE, DEFAULT_NUM_REPORTS); > + test_invalid_arguments(fd, 255, p_rate, DEFAULT_NUM_REPORTS); > } > > static void test_invalid_sampling_rate(int fd) > { > - test_invalid_arguments(fd, 0, 251 * 10, DEFAULT_NUM_REPORTS); > + test_invalid_arguments(fd, 0, p_rate * 10, DEFAULT_NUM_REPORTS); > } > > static void test_invalid_event_report_count(int fd) > { > - test_invalid_arguments(fd, 0, DEFAULT_SAMPLE_RATE, > + test_invalid_arguments(fd, 0, p_rate, > NUM_DATA_ROWS(512 * 1024) * MAX_XECORES + 1); > } > > @@ -387,7 +386,7 @@ static void test_non_privileged_access(int drm_fd) > igt_fork(child, 1) { > uint64_t properties[] = { > DRM_XE_EU_STALL_PROP_GT_ID, p_gt_id, > - DRM_XE_EU_STALL_PROP_SAMPLE_RATE, DEFAULT_SAMPLE_RATE, > + DRM_XE_EU_STALL_PROP_SAMPLE_RATE, p_rate, > DRM_XE_EU_STALL_PROP_WAIT_NUM_REPORTS, p_num_reports, > }; > > @@ -409,7 +408,7 @@ static void test_non_privileged_access(int drm_fd) > igt_fork(child, 1) { > uint64_t properties[] = { > DRM_XE_EU_STALL_PROP_GT_ID, p_gt_id, > - DRM_XE_EU_STALL_PROP_SAMPLE_RATE, DEFAULT_SAMPLE_RATE, > + DRM_XE_EU_STALL_PROP_SAMPLE_RATE, p_rate, > DRM_XE_EU_STALL_PROP_WAIT_NUM_REPORTS, p_num_reports, > }; > > @@ -647,7 +646,7 @@ static struct option long_options[] = { > igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL) > { > bool blocking_read = true; > - int drm_fd, ret; > + int drm_fd, ret, idx; > uint32_t devid; > struct stat sb; > struct drm_xe_device_query query = { > @@ -679,8 +678,11 @@ igt_main_args("e:g:o:r:u:w:", long_options, help_str, opt_handler, NULL) > igt_assert_eq(igt_ioctl(drm_fd, DRM_IOCTL_XE_DEVICE_QUERY, &query), 0); > > igt_assert(query_eu_stall_data->num_sampling_rates > 0); > - if (p_rate == 0) > - p_rate = query_eu_stall_data->sampling_rates[0]; > + /* If the user doesn't pass a sampling rate, use a mid sampling rate */ > + if (p_rate == 0) { > + idx = query_eu_stall_data->num_sampling_rates / 2; > + p_rate = query_eu_stall_data->sampling_rates[idx]; > + } > > if (output_file) { > output = fopen(output_file, "w"); > -- > 2.48.1 >