From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ADF45CD1284 for ; Thu, 4 Apr 2024 04:16:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4B2B91132D9; Thu, 4 Apr 2024 04:16:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="PIo2p5nX"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id AC7911132DE for ; Thu, 4 Apr 2024 04:16:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712204176; x=1743740176; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=X7lZuiALzF8YF7jVgv9IFT7XYWMLS6tkNFfWSRDGm1c=; b=PIo2p5nXVkxxPflQBwJX2jFL0wpjzBds1IEx/updvf2o6BQ5TDrMVRon iPYh/ui+yFmyVCY/0grxwosaUyP/UM3Ki/1oUr0IqBufKIctWldftvw0Y 6Tr2VA31YB0ByRlzJsk/QSJj5vLxo0sXy5ajjyLPlr+5E+AEZkBSbWIc2 lZ73fdW7/ekf6w0iu7rQ1aUtxCH3A2icK36LXETwtU6UZBjD38fgbCC6F A2lFoGk9Zs4quFxPGe9wEkZAZHcuEj4NFROfhg4AXjrykpIQHWZ3cBnZG IcfBYcyqcZiwpG8SrLZ3GdNcxnfnvMw3xpInLE0HxKBeD5eqVAB56d60J A==; X-CSE-ConnectionGUID: VHeoO1NTQ8Sc46rV7LE8CA== X-CSE-MsgGUID: xbNxgBKDTkKYQCvawp+NhA== X-IronPort-AV: E=McAfee;i="6600,9927,11033"; a="7331235" X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="7331235" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 21:16:16 -0700 X-CSE-ConnectionGUID: RvDzgMkRROWLIqmR/4i9WQ== X-CSE-MsgGUID: 8VVMqD1IQKCs193iZbZ/GA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,178,1708416000"; d="scan'208";a="49878805" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.138]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2024 21:16:16 -0700 Date: Wed, 03 Apr 2024 21:16:15 -0700 Message-ID: <85wmpdvk34.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Karthik Poosa Cc: intel-xe@lists.freedesktop.org, anshuman.gupta@intel.com, badal.nilawar@intel.com, rodrigo.vivi@intel.com, lucas.demarchi@intel.com Subject: Re: [PATCH v5 1/4] drm/xe: Define XE_REG_IS_VALID In-Reply-To: <20240404035441.965590-2-karthik.poosa@intel.com> References: <20240404035441.965590-1-karthik.poosa@intel.com> <20240404035441.965590-2-karthik.poosa@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Wed, 03 Apr 2024 20:54:38 -0700, Karthik Poosa wrote: > > Add macro to check if struct xe_reg has valid address. (Lucas, Badal). > > Signed-off-by: Karthik Poosa > --- > drivers/gpu/drm/xe/regs/xe_reg_defs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/xe/regs/xe_reg_defs.h b/drivers/gpu/drm/xe/regs/xe_reg_defs.h > index c89ef2b79a3f..42078643be6b 100644 > --- a/drivers/gpu/drm/xe/regs/xe_reg_defs.h > +++ b/drivers/gpu/drm/xe/regs/xe_reg_defs.h > @@ -131,4 +131,6 @@ struct xe_reg_mcr { > .__reg = XE_REG_INITIALIZER(r_, ##__VA_ARGS__, .mcr = 1) \ > }) > > +#define XE_REG_IS_VALID(r) ((r.addr) ? true : false) If this macro is needed, it can just be: #define XE_REG_IS_VALID(r) (r.addr)