From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EA38C021AA for ; Tue, 18 Feb 2025 23:11:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6E7FC10E156; Tue, 18 Feb 2025 23:11:04 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="RZU1cj5L"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEA6D10E156 for ; Tue, 18 Feb 2025 23:11:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1739920263; x=1771456263; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version:content-transfer-encoding; bh=JyDNhXIQipRU3Dryi4jq7JQ3VdGukR1si9p2YzskzsE=; b=RZU1cj5LlMPmkn6qNzpKYZ7J65umbBxNQCoG9EFhKDAPudVfLvJP5uB9 SQ7VUCuQnGj157aLTTXmeUAbTrOwpoh5fC6X6vBza2qeCHnWTJ+nJ2GGa gSkSv9GRDSJ4/+P+1JozPIq1huyDZ2zruB1VA1380AkRHwsZ90bKc9nVA rmnEDs+hPRuntEudMW9Ja9rnKCqFGhuKzG44AYou/eEszJnIOAjJUuzej eqnwpN4zN63uWVAx8dCipDk1Co7rtQP/BzxUa5tdBVBKi+UqV/1HIoe7k QhGcJhHods6g53SNOgbDn/vawy+H55Ij197ztueqi+EQdmt0zWibBo2tF A==; X-CSE-ConnectionGUID: 974QqjEZQdW6CaBkOk/03g== X-CSE-MsgGUID: pbdU4rFJRWiBc3DN7bWwvA== X-IronPort-AV: E=McAfee;i="6700,10204,11348"; a="39829295" X-IronPort-AV: E=Sophos;i="6.13,296,1732608000"; d="scan'208";a="39829295" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 15:11:02 -0800 X-CSE-ConnectionGUID: BRoQZf+0THGA1hrl37E4Mw== X-CSE-MsgGUID: sJSyJ1WoQNmcyNiDx1G+Ow== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,224,1728975600"; d="scan'208";a="119741340" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by orviesa005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2025 15:11:02 -0800 Date: Tue, 18 Feb 2025 15:11:01 -0800 Message-ID: <85y0y2onlm.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Harish Chegondi Cc: Subject: Re: [PATCH v10 2/8] drm/xe/uapi: Introduce API for EU stall sampling In-Reply-To: <74f50f665fee612954ef1670e2b9d87eec22ad83.1739906138.git.harish.chegondi@intel.com> References: <74f50f665fee612954ef1670e2b9d87eec22ad83.1739906138.git.harish.chegondi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" On Tue, 18 Feb 2025 11:53:52 -0800, Harish Chegondi wrote: > > diff --git a/drivers/gpu/drm/xe/xe_eu_stall.c b/drivers/gpu/drm/xe/xe_eu_= stall.c > new file mode 100644 > index 000000000000..79af41be9c02 > --- /dev/null > +++ b/drivers/gpu/drm/xe/xe_eu_stall.c > @@ -0,0 +1,218 @@ > +// SPDX-License-Identifier: MIT > +/* > + * Copyright =A9 2025 Intel Corporation > + */ > + > +#include > +#include > +#include > +#include > + > +#include > + > +#include "xe_device.h" > +#include "xe_eu_stall.h" > +#include "xe_gt_printk.h" > +#include "xe_gt_topology.h" > +#include "xe_macros.h" > +#include "xe_observation.h" > + > +/** > + * struct eu_stall_open_properties - EU stall sampling properties receiv= ed > + * from user space at open. > + * @sampling_rate_mult: EU stall sampling rate multiplier. > + * HW will sample every (sampling_rate_mult x 251) cycles. > + * @wait_num_reports: Minimum number of EU stall data reports to unblock= poll(). > + * @gt: GT on which EU stall data will be captured. > + */ > +struct eu_stall_open_properties { > + unsigned int sampling_rate_mult; > + unsigned int wait_num_reports; Did you see Jani N's mail? These need to be changed to int (for me either int or u32 is fine). With that addressed, the rest of the patch lgtm now, so this is: Reviewed-by: Ashutosh Dixit