From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
Cc: <igt-dev@lists.freedesktop.org>
Subject: Re: [PATCH i-g-t v3 2/3] tests/intel/xe_oa: Reduce the number of mmap reports checked
Date: Mon, 13 Jan 2025 11:22:05 -0800 [thread overview]
Message-ID: <85y0zeecyq.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250113061949.753864-3-sai.teja.pottumuttu@intel.com>
On Sun, 12 Jan 2025 22:19:48 -0800, Sai Teja Pottumuttu wrote:
>
> Currently, 20 mmap periodic reports are checked which seems unnecessary,
> reduce it to 10.
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
>
> Signed-off-by: Sai Teja Pottumuttu <sai.teja.pottumuttu@intel.com>
> ---
> tests/intel/xe_oa.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/intel/xe_oa.c b/tests/intel/xe_oa.c
> index ad3526406..cd081ecff 100644
> --- a/tests/intel/xe_oa.c
> +++ b/tests/intel/xe_oa.c
> @@ -4378,7 +4378,7 @@ static void check_reports(void *oa_vaddr, uint32_t oa_size,
> uint32_t timer_reports = 0;
>
> for (reports = (uint32_t *)oa_vaddr;
> - timer_reports < 20 && reports[0] && oa_timestamp(reports, fmt);
> + timer_reports < 10 && reports[0] && oa_timestamp(reports, fmt);
> reports += report_words) {
> if (!oa_report_is_periodic(reports))
> continue;
> --
> 2.34.1
>
next prev parent reply other threads:[~2025-01-13 19:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-13 6:19 [PATCH i-g-t v3 0/3] Miscellaneous OA Refactors Sai Teja Pottumuttu
2025-01-13 6:19 ` [PATCH i-g-t v3 1/3] tests/intel/xe_oa: Remove unused function arguments Sai Teja Pottumuttu
2025-01-13 6:19 ` [PATCH i-g-t v3 2/3] tests/intel/xe_oa: Reduce the number of mmap reports checked Sai Teja Pottumuttu
2025-01-13 19:22 ` Dixit, Ashutosh [this message]
2025-01-13 6:19 ` [PATCH i-g-t v3 3/3] tests/intel/xe_oa: Remove hardcoded time heuristics Sai Teja Pottumuttu
2025-01-13 19:37 ` Dixit, Ashutosh
2025-01-13 21:17 ` ✓ i915.CI.BAT: success for Miscellaneous OA Refactors (rev3) Patchwork
2025-01-13 21:18 ` ✓ Xe.CI.BAT: " Patchwork
2025-01-15 7:13 ` ✗ i915.CI.Full: failure " Patchwork
2025-01-17 8:00 ` ✗ Xe.CI.Full: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85y0zeecyq.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=igt-dev@lists.freedesktop.org \
--cc=sai.teja.pottumuttu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.