From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2CABC02180 for ; Mon, 13 Jan 2025 18:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9248010E2A5; Mon, 13 Jan 2025 18:42:54 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="LO7qvq9b"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAC1710E2A5 for ; Mon, 13 Jan 2025 18:42:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1736793774; x=1768329774; h=date:message-id:from:to:cc:subject:in-reply-to: references:mime-version; bh=tRhTGAhCpB7l4DVgE847UeaMlPpaquSBwAQn8/v0du0=; b=LO7qvq9bzxKwEF8PIX3/5PR2BMfqkGQYSmAo98ylBFIHrBDkhzuBwhZG /PAPMb3qto2iUzBli2HoevmqlCjZfgTSK4w/auTg073hG6U0rBGYm9P9Q GrWyKpZ9D/pKARKCEzkVSZ/6jUFpPbA5h+KaY4fwY7OMf7vkO3hBgVuWM UKGf42MLhV0sz1lNMN6E+0eUgVNr+Lsq+mX1N2ERo5ANO0bc8gyk31ngf qf24WBw9eeo1XxTSpsBWb7szgIoiIVG/mHOsDKZ7Tfp5aFqOVak5EMM9X 1W1TQXZ0O6WHPQYPipGIoX5tUXrE+z2gUpoMT5rHOuoxYUOJUZKjMfms1 g==; X-CSE-ConnectionGUID: eRMdMayiRlu3n9v6jRAJOw== X-CSE-MsgGUID: wvBVRcxwQ3uhEB3xjFrOyw== X-IronPort-AV: E=McAfee;i="6700,10204,11314"; a="47647022" X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="47647022" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2025 10:42:53 -0800 X-CSE-ConnectionGUID: ICJ84yTTQEiQjfmQjVYX2w== X-CSE-MsgGUID: juFp9tQmRXSLuaa0SMve5A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.12,310,1728975600"; d="scan'208";a="105084360" Received: from orsosgc001.jf.intel.com (HELO orsosgc001.intel.com) ([10.165.21.142]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2025 10:42:53 -0800 Date: Mon, 13 Jan 2025 10:42:52 -0800 Message-ID: <85zfjuees3.wl-ashutosh.dixit@intel.com> From: "Dixit, Ashutosh" To: Lucas De Marchi Cc: intel-gfx@lists.freedesktop.org Subject: Re: [PATCH] drm/i915/pmu: Remove i915_pmu_event_event_idx() In-Reply-To: <20250113183329.3138138-1-lucas.demarchi@intel.com> References: <20250113183329.3138138-1-lucas.demarchi@intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (x86_64-redhat-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Mon, 13 Jan 2025 10:33:29 -0800, Lucas De Marchi wrote: > > perf event already has a default function that returns 0, no need to > override with the same thing. Reviewed-by: Ashutosh Dixit > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/i915_pmu.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_pmu.c b/drivers/gpu/drm/i915/i915_pmu.c > index e55db036be1bb..2eecd42f61ba1 100644 > --- a/drivers/gpu/drm/i915/i915_pmu.c > +++ b/drivers/gpu/drm/i915/i915_pmu.c > @@ -891,11 +891,6 @@ static void i915_pmu_event_del(struct perf_event *event, int flags) > i915_pmu_event_stop(event, PERF_EF_UPDATE); > } > > -static int i915_pmu_event_event_idx(struct perf_event *event) > -{ > - return 0; > -} > - > struct i915_str_attribute { > struct device_attribute attr; > const char *str; > @@ -1301,7 +1296,6 @@ void i915_pmu_register(struct drm_i915_private *i915) > pmu->base.start = i915_pmu_event_start; > pmu->base.stop = i915_pmu_event_stop; > pmu->base.read = i915_pmu_event_read; > - pmu->base.event_idx = i915_pmu_event_event_idx; > > ret = perf_pmu_register(&pmu->base, pmu->name, -1); > if (ret) > -- > 2.48.0 >