From mboxrd@z Thu Jan  1 00:00:00 1970
From: Roman Mashak <mrv@mojatatu.com>
Subject: Re: [PATCH iproute2-next] tc: m_tunnel_key: Add tunnel option support to act_tunnel_key
Date: Fri, 06 Jul 2018 09:32:55 -0400
Message-ID: <85zhz4pjzs.fsf@mojatatu.com>
References: <20180706001200.29567-1-jakub.kicinski@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain
Cc: dsahern@gmail.com, stephen@networkplumber.org,
        oss-drivers@netronome.com, netdev@vger.kernel.org,
        Simon Horman <simon.horman@netronome.com>,
        Pieter Jansen van Vuuren
        <pieter.jansenvanvuuren@netronome.com>
To: Jakub Kicinski <jakub.kicinski@netronome.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-it0-f47.google.com ([209.85.214.47]:37090 "EHLO
        mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S932205AbeGFNc6 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 6 Jul 2018 09:32:58 -0400
Received: by mail-it0-f47.google.com with SMTP id p17-v6so17097967itc.2
        for <netdev@vger.kernel.org>; Fri, 06 Jul 2018 06:32:57 -0700 (PDT)
In-Reply-To: <20180706001200.29567-1-jakub.kicinski@netronome.com> (Jakub
        Kicinski's message of "Thu, 5 Jul 2018 17:12:00 -0700")
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>

Jakub Kicinski <jakub.kicinski@netronome.com> writes:

> From: Simon Horman <simon.horman@netronome.com>
>
> Allow setting tunnel options using the act_tunnel_key action.
>
> Options are expressed as class:type:data and multiple options
> may be listed using a comma delimiter.
>
>  # ip link add name geneve0 type geneve dstport 0 external
>  # tc qdisc add dev eth0 ingress
>  # tc filter add dev eth0 protocol ip parent ffff: \
>      flower indev eth0 \
>         ip_proto udp \
>         action tunnel_key \
>             set src_ip 10.0.99.192 \
>             dst_ip 10.0.99.193 \
>             dst_port 6081 \
>             id 11 \
>             geneve_opts 0102:80:00800022,0102:80:00800022 \
>     action mirred egress redirect dev geneve0

[...]

Jakub, could you also add relevant tests for the new option in file
$(kernel)/tools/testing/selftests/tc-testing/tc-tests/actions/tunnel_key.json?