From: Christian Schoenebeck <linux_oss@crudebyte.com>
To: Pierre Barre <pierre@barre.sh>,
Dominique Martinet <asmadeus@codewreck.org>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
v9fs@lists.linux.dev, ericvh@kernel.org, lucho@ionkov.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 9p: Use kvmalloc for message buffers
Date: Fri, 08 Aug 2025 13:12:08 +0200 [thread overview]
Message-ID: <8602724.2ttRNpPraX@silver> (raw)
In-Reply-To: <aJPMwqqchOaZFSqn@codewreck.org>
On Wednesday, August 6, 2025 11:44:34 PM CEST Dominique Martinet wrote:
>
> Pierre Barre wrote on Wed, Aug 06, 2025 at 05:50:42PM +0200:
> > If I submit a patch based on what has been discussed above, is it
> > likely to be accepted? Unfortunately, in my current setup, I am
> > encountering this issue quite frequently, and users of my servers are
> > having a hard time making sense of the error.
>
> Yes, sorry it wasn't clear.
>
> I still have no idea what's the "best" allocation method that we'll be
> able to use as either a vmalloc buffer or split into a scatterlist, but
> there's little point in worrying too much about it, so please go ahead.
>
> If it's restricted to trans_fd and there's a chance we can make use of
> it with (at least) virtio later I think everyone will be happy :)
Yes, sounds like a viable plan.
Pierre, one more thing to note: kmem_cache_alloc() might still fail though. So
maybe it would make sense to add a separate patch that would check the result
of kmem_cache_alloc() and if it fails, falling back to your kvmalloc() call
(if enabled by the discussed transport mechanism of course).
/Christian
next prev parent reply other threads:[~2025-08-08 11:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-30 15:08 [PATCH] 9p: Use kvmalloc for message buffers Pierre Barre
2025-07-30 16:08 ` Christian Schoenebeck
2025-07-30 16:19 ` Pierre Barre
2025-07-30 17:28 ` Christian Schoenebeck
2025-07-30 20:16 ` Pierre Barre
2025-07-30 22:07 ` asmadeus
2025-07-31 0:36 ` Pierre Barre
2025-08-06 15:50 ` Pierre Barre
2025-08-06 21:44 ` Dominique Martinet
2025-08-08 11:12 ` Christian Schoenebeck [this message]
2025-10-16 7:01 ` [PATCH v2] 9p: Use kvmalloc for message buffers on supported transports Pierre Barre
2025-10-16 7:26 ` Dominique Martinet
2025-10-16 13:06 ` Christian Schoenebeck
2025-10-16 13:58 ` [PATCH v3] " Pierre Barre
2025-10-17 5:49 ` Christophe JAILLET
2025-11-03 7:52 ` asmadeus
2025-11-03 10:16 ` Pierre Barre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8602724.2ttRNpPraX@silver \
--to=linux_oss@crudebyte.com \
--cc=asmadeus@codewreck.org \
--cc=ericvh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucho@ionkov.net \
--cc=pierre@barre.sh \
--cc=v9fs@lists.linux.dev \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.