From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Andrew Rybchenko <arybchenko@solarflare.com>,
Reshma Pattan <reshma.pattan@intel.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
Shreyansh Jain <shreyansh.jain@nxp.com>,
Ashish Gupta <ashish.gupta@cavium.com>,
Fiona Trahe <fiona.trahe@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Akhil Goyal <akhil.goyal@nxp.com>,
Declan Doherty <declan.doherty@intel.com>,
Fan Zhang <roy.fan.zhang@intel.com>,
Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
Gaetan Rivet <gaetan.rivet@6wind.com>,
Qi Zhang <qi.z.zhang@intel.com>,
Xiao Wang <xiao.w.wang@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Wenzhuo Lu <wenzhuo.lu@intel.com>,
Konstantin Ananyev <konstantin.ananyev@intel.com>,
Rasesh Mody <rasesh.mody@cavium.com>,
Harish Patil <harish.patil@cavium.com>,
Shahed Shaikh <shahed.shaikh@cavium.com>,
Jasvinder Singh <jasvinder.singh@intel.com>,
Cristian D
Subject: Re: [PATCH v2 1/4] add missing static keyword to globals
Date: Sun, 28 Oct 2018 12:04:23 +0100 [thread overview]
Message-ID: <8612622.zZWGxMPIhl@xps> (raw)
In-Reply-To: <bf870874-bc3d-a142-119b-608aea894536@solarflare.com>
05/10/2018 17:55, Andrew Rybchenko:
> On 10/5/18 7:26 PM, Ferruh Yigit wrote:
> > --- a/drivers/net/sfc/sfc_rx.c
> > +++ b/drivers/net/sfc/sfc_rx.c
> > -struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
> > +static struct sfc_rss_hf_rte_to_efx sfc_rss_hf_map[] = {
>
> I'd prefer "static const" in fact
Yes, please add const to such structures in a v3.
next prev parent reply other threads:[~2018-10-28 11:04 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 3:40 [PATCH] fix static variables Ferruh Yigit
2018-10-05 8:38 ` Rao, Nikhil
2018-10-05 16:26 ` [PATCH v2 1/4] add missing static keyword to globals Ferruh Yigit
2018-10-05 15:55 ` Andrew Rybchenko
2018-10-28 11:04 ` Thomas Monjalon [this message]
2018-10-05 16:26 ` [PATCH v2 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-05 16:27 ` Maxime Coquelin
2018-10-08 12:18 ` Shreyansh Jain
2018-10-10 5:56 ` Zhang, Tianfei
2018-10-05 16:26 ` [PATCH v2 3/4] fix global variable issues Ferruh Yigit
2018-10-07 12:21 ` Jerin Jacob
2018-10-05 16:26 ` [PATCH v2 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-07 12:22 ` Jerin Jacob
2018-10-08 8:45 ` Shreyansh Jain
2018-10-08 9:11 ` Ferruh Yigit
2018-10-08 9:27 ` Shreyansh Jain
2018-10-07 12:18 ` [PATCH v2 1/4] add missing static keyword to globals Jerin Jacob
2018-10-08 9:43 ` Shreyansh Jain
2018-10-28 23:57 ` [PATCH v3 " Ferruh Yigit
2018-10-28 23:57 ` [PATCH v3 2/4] drivers: prefix global variables with module name Ferruh Yigit
2018-10-28 23:57 ` [PATCH v3 3/4] fix global variable issues Ferruh Yigit
2018-10-29 6:57 ` Hyong Youb Kim
2018-10-28 23:57 ` [PATCH v3 4/4] lib: reduce global variable usage Ferruh Yigit
2018-10-29 1:35 ` Thomas Monjalon
2018-10-10 6:23 ` [PATCH] fix static variables Zhang, Tianfei
2018-10-11 6:56 ` Xing, Beilei
2018-11-02 11:09 ` Cel, TomaszX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8612622.zZWGxMPIhl@xps \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=arybchenko@solarflare.com \
--cc=ashish.gupta@cavium.com \
--cc=beilei.xing@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=fiona.trahe@intel.com \
--cc=gaetan.rivet@6wind.com \
--cc=harish.patil@cavium.com \
--cc=hemant.agrawal@nxp.com \
--cc=jasvinder.singh@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=qi.z.zhang@intel.com \
--cc=rahul.lakkireddy@chelsio.com \
--cc=rasesh.mody@cavium.com \
--cc=reshma.pattan@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=shahed.shaikh@cavium.com \
--cc=shreyansh.jain@nxp.com \
--cc=wenzhuo.lu@intel.com \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.