From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7787E472081; Tue, 15 Sep 2026 09:20:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789464026; cv=none; b=ZmzDLsSp1agYVDTb51Yc++Aeh+KeW8QO0bSli8zACAL0dS4x4NrkU5kZUtzhsX05EJaj1vK6YXHMA+YzozFccgSRM6ki5lk11YH0qyrXvaCO5VeoKF7u/HuFN8dSnztWOHlCg/4UJ4PgWKbAlMPOrSgnTr8Bz/Xz/lczsr/tDTc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789464026; c=relaxed/simple; bh=26Prvv4ObEV7ZWfzxYx+8ZTFd9nlpUgjnOhYz1ktl3M=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=He10oe0pP6LQQEvQ/A/Og/MjEVbQ1UbJ/koMzURq5c5XFLhQ2yUb+2JVGax0X50KPm3N1ZVh9Ccyt1D0fvkpzBKOyXRadG4HcoEWutZi6zIgbG3NSAkO/dM2DgpN8WBx9pVNJY60CefK0sxPW6n8EbYgiChcNRPUJyi6IfgEnhg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=bqJllKoF; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="bqJllKoF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 233891F000FF; Tue, 15 Sep 2026 09:20:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789464025; bh=Gsfj64LTrr6T9ViJJFtqRYRZOhyDWuM3jZo4VsxBbsg=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=bqJllKoFYaoUJKKNTxyQfhB2fqK4oMEt/YrWjKVpzKz090aVWkljd5TIY5ogmH1ti mdl5vmN+ZAWYM+P5T+peGa/20+3hqqGgRFolwXG46xZhSwkbFz+oQlZaABRh+72xQ+ O/UwTm6/YOWk+YRdUmuHXAIjhXMNZrwWZL3/2ZK8VZ/PUoNxnqLOhKMt7QRecUWrz1 1+IoTF/9BW7yNghJjLDSWUco5CMLa6Jz9B6NVS6PzDrU6qQdmXBKXuLQzYNrXa44WE B/dw3xcMOMeaBqQ0SZ6mtX8uoDnE0nDVTPxjjICm41uYr8dNoEVDc/XW/htbaE2KXs X+v5ICcpie9Mw== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1x6PKw-000000091Sw-3mZd; Tue, 15 Sep 2026 09:20:22 +0000 Date: Tue, 15 Sep 2026 10:20:22 +0100 Message-ID: <861pau7twp.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: sashiko-reviews@lists.linux.dev, Oliver Upton , kvmarm@lists.linux.dev Subject: Re: [PATCH] KVM: arm64: Reject the stage-2 MMU pointer hypercalls under pKVM In-Reply-To: References: <20260914174521.832575-1-fuad.tabba@linux.dev> <20260914175832.2A2D91F000FF@smtp.kernel.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, sashiko-reviews@lists.linux.dev, oupton@kernel.org, kvmarm@lists.linux.dev X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Mon, 14 Sep 2026 19:11:59 +0100, Fuad Tabba wrote: > > On Mon, 14 Sept 2026 at 18:58, wrote: > > > > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: > > > > Pre-existing issues: > > - [Critical] Hypercall handlers `handle___kvm_adjust_pc`, `handle___vgic_v5_save_apr`, and `handle___vgic_v5_restore_vmcr_apr` dereference host-provided pointers via `kern_hyp_va()` without validation, allowing a malicious host to corrupt EL2-private memory under pKVM. > > All three are correct, and all three are already being fixed. > handle___kvm_adjust_pc in [1], the GICv5 handlers in [2], and the rest > in this patch. But that's part of the problem. I see a bunch of random patches addressing similar problems, sent without any logic. You really need to group related patches together, because the only possible outcome of your current way of posting things is that I'll drop something on the floor. M. -- Without deviation from the norm, progress is not possible.