From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EF04DC4451C for ; Tue, 21 Jul 2026 06:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: References:In-Reply-To:Subject:Cc:To:From:Message-ID:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ecPqk7dPmScIh6Av3W0D+6bpYM48TCqyyw+XursOn7w=; b=YFA4fq5uih85wom4VXefOr2A2a Ou0+SRv6CJmr7Q24w0raX9K4AZtMlr2ryxnNnARVRd7b12FuhItorkiDRzI32XnuWpMgm87yohykr r9ad8NXqQJ8Etv1ZsDICxRxsi71Ef35ppETlRzOlzZF1dK3k/yomt5BknRN2jPVbnv/APgM0av9Dq g5nVOjOF7YaDovfaQwDQXAF3+7oboDJbINEcdzS7H4UMNxh3qw0/C7+IfVbU1K1BYnhyBt7WclD6d eJMUksNrODq47q7ql4iNh6KXa309Wo3/HyY0GMExPNh6Z+jdac4PDNQvQ5hZvnbAd7uMYcqJb0xIl AdF0vLvA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1wm4LB-00000008Zfh-0YTn; Tue, 21 Jul 2026 06:52:33 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1wm4LA-00000008Zfa-2SAh for linux-arm-kernel@lists.infradead.org; Tue, 21 Jul 2026 06:52:32 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 90F6660A8E; Tue, 21 Jul 2026 06:52:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43E181F000E9; Tue, 21 Jul 2026 06:52:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1784616751; bh=ecPqk7dPmScIh6Av3W0D+6bpYM48TCqyyw+XursOn7w=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=Mjn7NJH1DoVyenPD36cyNInYRA2icOYNKmPRaBkUE/vN01rOF7J8Q3dmPKqCmhAho bHgeGehcddg79YLm3MHJE/bM9WSZei+cctH1qtTTyMPoWKVbpsnoePLsrNC2jhDUZ9 k2jIvIrqfHGR7Esy//Gk1JjQMuqV5HfU/BBLa3AKITpd7be1j17lXfSYg1A9RpAs9H pFEoot4n0MmOAFcYsmPxJrYK6OdFxydIwH63P3a8oCgqo0OryUVYkasGrKArxpwy0/ j4FV0PAiulOGKdeVljZ0biuBRk7MwiSlsH6ORwefsW+kVonnO6/aATgb3s3RIPYEXE 6Jg1tFQoPDsww== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wm4L7-000000075j7-1fSw; Tue, 21 Jul 2026 06:52:29 +0000 Date: Tue, 21 Jul 2026 07:52:28 +0100 Message-ID: <861pcwg7gz.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: Vincent Donnefort , oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, kernel-team@android.com Subject: Re: [PATCH v2] KVM: arm64: Fix hyp_trace clock disabling In-Reply-To: References: <20260715105100.3178255-1-vdonnefort@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: fuad.tabba@linux.dev, vdonnefort@google.com, oupton@kernel.org, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, joey.gouly@arm.com, seiden@linux.ibm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, kernel-team@android.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 20 Jul 2026 20:45:00 +0100, Fuad Tabba wrote: > > Hi Vincent, > > On Wed, 15 Jul 2026 at 11:51, Vincent Donnefort wrote: > > > > Fix the disable path in hyp_trace_clock_enable(), which fell through to > > re-initialize and reschedule the clock after cancelling the work. Return > > early instead. > > > > While at it, cleanup hyp_trace_clock::lock which is unused and > > hyp_trace_clock::running which is redundant: the trace_remote framework > > already serializes calls to the callback enable_tracing. > > Although the cleanup and the fix are to the same commit, could this be > split into the fix and the lock/running cleanup as a separate patch? > Since b22888917fa41 is already in a released kernel, the fix will > likely go to stable, and it'd be nice to keep that backport to just > the behavioural change. Not sure I get what you mean here. From what I can see, this patch fully applies to b22888917fa41. Given that this is the third version for something that trivial (two from Vincent, one from you), can we please agree on *something* quickly? Thanks, M. -- Without deviation from the norm, progress is not possible.