From: Marc Zyngier <maz@kernel.org>
To: Hanjun Guo <guohanjun@huawei.com>
Cc: <linux-kernel@vger.kernel.org>, <linux-acpi@vger.kernel.org>,
Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>,
Sudeep Holla <sudeep.holla@arm.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] ACPI: GTDT: Correctly number platform devices for MMIO timers
Date: Fri, 21 Nov 2025 08:55:50 +0000 [thread overview]
Message-ID: <861plrsr1l.wl-maz@kernel.org> (raw)
In-Reply-To: <c1edd6cc-0542-8d22-6edc-60c619c9e162@huawei.com>
On Fri, 21 Nov 2025 02:53:17 +0000,
Hanjun Guo <guohanjun@huawei.com> wrote:
>
> On 2025/10/30 19:01, Marc Zyngier wrote:
> > Use the actual timer counter instead of the watchdog counter.
> >
> > Fixes: 5669d92f3efa4 ("ACPI: GTDT: Generate platform devices for MMIO timers")
> > Reported-by: Pavan Kondeti <pavan.kondeti@oss.qualcomm.com>
> > Signed-off-by: Marc Zyngier <maz@kernel.org>
> > Cc: Hanjun Guo <guohanjun@huawei.com>
> > Cc: Sudeep Holla <sudeep.holla@arm.com>
> > Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> > Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
> > Cc: Thomas Gleixner <tglx@linutronix.de>
> > Cc: Mark Rutland <mark.rutland@arm.com>
> > ---
> > drivers/acpi/arm64/gtdt.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/acpi/arm64/gtdt.c b/drivers/acpi/arm64/gtdt.c
> > index fd995a1d3d248..8cc8af8fd408c 100644
> > --- a/drivers/acpi/arm64/gtdt.c
> > +++ b/drivers/acpi/arm64/gtdt.c
> > @@ -430,10 +430,10 @@ static int __init gtdt_platform_timer_init(void)
> > continue;
> > pdev = platform_device_register_data(NULL,
> > "gtdt-arm-mmio-timer",
> > - gwdt_count, &atm,
> > + mmio_timer_count, &atm,
> > sizeof(atm));
> > if (IS_ERR(pdev)) {
> > - pr_err("Can't register timer %d\n", gwdt_count);
> > + pr_err("Can't register timer %d\n", mmio_timer_count);
> > continue;
> > }
>
> "typo" I think :)
>
> Acked-by: Hanjun Guo <guohanjun@huawei.com>
>
> Will this go via ARM64 tree?
Is that where the ACPI updates are routed to? This fixes a patch that
was routed tip, so I'd have expected this to go via the same route.
In any case, I've added Catalin and Will on Cc.
Thanks,
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2025-11-21 8:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-30 11:01 [PATCH] ACPI: GTDT: Correctly number platform devices for MMIO timers Marc Zyngier
2025-11-20 13:58 ` Marc Zyngier
2025-11-21 2:53 ` Hanjun Guo
2025-11-21 8:55 ` Marc Zyngier [this message]
2025-11-21 13:14 ` Hanjun Guo
2025-11-27 15:07 ` Will Deacon
2025-11-29 6:02 ` Hanjun Guo
2025-12-01 13:34 ` Will Deacon
2025-11-24 14:41 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861plrsr1l.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=guohanjun@huawei.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavan.kondeti@oss.qualcomm.com \
--cc=rafael@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.