From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C89FFC00A5A for ; Thu, 19 Jan 2023 09:55:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229924AbjASJzC (ORCPT ); Thu, 19 Jan 2023 04:55:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34564 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230280AbjASJyz (ORCPT ); Thu, 19 Jan 2023 04:54:55 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 546435D106 for ; Thu, 19 Jan 2023 01:54:54 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E636060B59 for ; Thu, 19 Jan 2023 09:54:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 540C6C433F0; Thu, 19 Jan 2023 09:54:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1674122093; bh=y7c7NqbbdZg32I6uaJ43JYiG4QLb3yxiDnBwhTViYDE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=RlUK30TfOiSPpN/bbClkFXsyswLks4nOsJXasioFl2de7TwM8qgv7er2miWELHcVS IVa1Op5u/RI+VIAr/xpTNbzCOh2bantBJAaBVBXniOCuMgfTvuUqGyNrHqHsjM+8Vi ossfId3gj2inTnWTmyFIVAbjbDsOMzSNb+PaB8e3gbjIpkxKJ00Zhj4XFManaJKqp3 8jD5BX9FafwRxVDv1YqgL5AvfACfyyBW1k7Q0hf1h3b72vO54XcL6rXPKfIlrb8NeU li0k3C7BJpAP7jUUjS5ADJZS53lTzJM3sI9INdwQu7AzMBLC8r3vYIfYZmt9t3wUll 7Xuh/BJXOqcnA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1pIRdC-00329l-Uk; Thu, 19 Jan 2023 09:54:51 +0000 Date: Thu, 19 Jan 2023 09:54:50 +0000 Message-ID: <861qnqonmd.wl-maz@kernel.org> From: Marc Zyngier To: Sean Christopherson Cc: Yu Zhang , kvm@vger.kernel.org, pbonzini@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org, paul@xen.org Subject: Re: [PATCH v5] KVM: MMU: Make the definition of 'INVALID_GPA' common In-Reply-To: References: <20230105130127.866171-1-yu.c.zhang@linux.intel.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/28.2 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: seanjc@google.com, yu.c.zhang@linux.intel.com, kvm@vger.kernel.org, pbonzini@redhat.com, james.morse@arm.com, alexandru.elisei@arm.com, suzuki.poulose@arm.com, oliver.upton@linux.dev, catalin.marinas@arm.com, will@kernel.org, paul@xen.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Thu, 19 Jan 2023 00:53:36 +0000, Sean Christopherson wrote: > > On Thu, Jan 05, 2023, Yu Zhang wrote: > > KVM already has a 'GPA_INVALID' defined as (~(gpa_t)0) in kvm_types.h, > > and it is used by ARM code. We do not need another definition of > > 'INVALID_GPA' for X86 specifically. > > > > Instead of using the common 'GPA_INVALID' for X86, replace it with > > 'INVALID_GPA', and change the users of 'GPA_INVALID' so that the diff > > can be smaller. Also because the name 'INVALID_GPA' tells the user we > > are using an invalid GPA, while the name 'GPA_INVALID' is emphasizing > > the GPA is an invalid one. > > > > No functional change intended. > > > > Signed-off-by: Yu Zhang > > Reviewed-by: Paul Durrant > > Reviewed-by: Sean Christopherson > > --- > > Marc and/or Oliver, > > Do you want to grab this since most of the changes are to arm64? > I'll happily take it through x86, but generating a conflict in arm64 > seems infinitely more likely. > Do you mind acking it then, at least for the x86 part? M. -- Without deviation from the norm, progress is not possible.