From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marc Zyngier Subject: Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort Date: Sun, 29 Oct 2017 01:12:32 +0000 Message-ID: <861slmaha7.fsf@arm.com> References: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> (Dongjiu Geng's message of "Sat, 28 Oct 2017 14:45:59 +0800") Sender: linux-kernel-owner@vger.kernel.org To: Dongjiu Geng Cc: christoffer.dall@linaro.org, linux@armlinux.org.uk, catalin.marinas@arm.com, will.deacon@arm.com, linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org, huangshaoyu@huawei.com, wuquanming@huawei.com List-Id: kvmarm@lists.cs.columbia.edu On Sat, Oct 28 2017 at 2:45:59 pm BST, Dongjiu Geng wrote: > For this matching, switch expression uses fault type which is > not {I,D}FSC value, but the case expression uses {I,D}FSC, > they are incompatible. So change the switch expression to > use {I,D}FSC. I'm sorry, but I can't manage to parse this commit message. How about something like this? "kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but calls kvm_vcpu_trap_get_fault_type() that only returns the fault class, thus reducing the scope of the check. This doesn't cause any observable bug yet as we end-up matching a closely related syndrome for which we return the same value. Using kvm_vcpu_trap_get_fault() instead fixes it for good" Otherwise: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 From: marc.zyngier@arm.com (Marc Zyngier) Date: Sun, 29 Oct 2017 01:12:32 +0000 Subject: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort In-Reply-To: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> (Dongjiu Geng's message of "Sat, 28 Oct 2017 14:45:59 +0800") References: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> Message-ID: <861slmaha7.fsf@arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, Oct 28 2017 at 2:45:59 pm BST, Dongjiu Geng wrote: > For this matching, switch expression uses fault type which is > not {I,D}FSC value, but the case expression uses {I,D}FSC, > they are incompatible. So change the switch expression to > use {I,D}FSC. I'm sorry, but I can't manage to parse this commit message. How about something like this? "kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but calls kvm_vcpu_trap_get_fault_type() that only returns the fault class, thus reducing the scope of the check. This doesn't cause any observable bug yet as we end-up matching a closely related syndrome for which we return the same value. Using kvm_vcpu_trap_get_fault() instead fixes it for good" Otherwise: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751676AbdJ2BMn (ORCPT ); Sat, 28 Oct 2017 21:12:43 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:43632 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751446AbdJ2BMm (ORCPT ); Sat, 28 Oct 2017 21:12:42 -0400 From: Marc Zyngier To: Dongjiu Geng Cc: , , , , , , , , Subject: Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort In-Reply-To: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> (Dongjiu Geng's message of "Sat, 28 Oct 2017 14:45:59 +0800") Organization: ARM Ltd References: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Date: Sun, 29 Oct 2017 01:12:32 +0000 Message-ID: <861slmaha7.fsf@arm.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Oct 28 2017 at 2:45:59 pm BST, Dongjiu Geng wrote: > For this matching, switch expression uses fault type which is > not {I,D}FSC value, but the case expression uses {I,D}FSC, > they are incompatible. So change the switch expression to > use {I,D}FSC. I'm sorry, but I can't manage to parse this commit message. How about something like this? "kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but calls kvm_vcpu_trap_get_fault_type() that only returns the fault class, thus reducing the scope of the check. This doesn't cause any observable bug yet as we end-up matching a closely related syndrome for which we return the same value. Using kvm_vcpu_trap_get_fault() instead fixes it for good" Otherwise: Acked-by: Marc Zyngier M. -- Jazz is not dead. It just smells funny.