From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kumar Gala Date: Mon, 31 Jan 2011 22:04:24 -0600 Subject: [U-Boot] [PATCH 4/6] powerpc/p1021: add more P1021 defines. In-Reply-To: References: <1296499317-26616-1-git-send-email-Haiying.Wang@freescale.com> <1296499317-26616-5-git-send-email-Haiying.Wang@freescale.com> Message-ID: <8622079F-F404-4AEC-B180-91F573159EDD@kernel.crashing.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On Jan 31, 2011, at 5:36 PM, Timur Tabi wrote: > On Mon, Jan 31, 2011 at 3:08 PM, Kumar Gala wrote: > >>> @@ -588,6 +588,9 @@ typedef struct qe_immap { >>> #elif defined(CONFIG_MPC8569) >>> u8 muram[0x20000]; /* 0x1_0000 - 0x3_0000 Multi-user RAM */ >>> u8 res17[0x10000]; /* 0x3_0000 - 0x4_0000 */ >>> +#elif defined(CONFIG_P1021) >>> + u8 muram[0x06000]; /* 0x1_0000 - 0x1_6000 Multi-user RAM */ >>> + u8 res17[0x1a000]; /* 0x1_6000 - 0x3_0000 */ >>> #else >>> u8 muram[0xC000]; /* 0x110000 - 0x11C000 Multi-user RAM */ >>> u8 res17[0x24000]; /* 0x11C000 - 0x140000 */ >> >> Can we reduce this mess with using QE_MURAM_SIZE? >> >> u8 muram[QE_MURAM_SIZE]; >> u8 res17[0xNNNN - QE_MURAM_SIZE]; > > I don't think we need res17, because nothing references it. That will > simplify it even more. Looks like qe_immap isn't embedded anywhere so should be ok (was concerned if the struct is expected to be a given size. - k