From: Wayne.Brown@altec.com
To: linux-kernel@vger.kernel.org
Subject: badly punctuated parameter list in `#define' (2.4.3-ac5 and 2.4.4 -pre2)
Date: Thu, 12 Apr 2001 14:03:56 -0500 [thread overview]
Message-ID: <86256A2C.0068BA0C.00@smtpnotes.altec.com> (raw)
When compiling 2.4.3-ac5 (and also 2.4.4-pre2) I get this:
/usr/src/linux-2.4.3-ac5/include/asm/rwsem.h:26: badly punctuated parameter list
in `#define'
This appears to be due to some code in rwsem.h that is written for a different
version of gcc. (I'm still using gcc-2.91.66 as specified in
Documentation/Changes.) It works for me if I replace it with the code in the
section labeled /* old gcc */. Here's a patch to do that:
--- include/asm-i386/rwsem.h.old Thu Apr 12 13:47:00 2001
+++ include/asm-i386/rwsem.h Thu Apr 12 13:48:04 2001
@@ -21,16 +21,16 @@
#include <linux/wait.h>
#if RWSEM_DEBUG
-#define rwsemdebug(FMT,...) do { if (sem->debug) printk(FMT,__VA_ARGS__); }
while(0)
+//#define rwsemdebug(FMT,...) do { if (sem->debug) printk(FMT,__VA_ARGS__); }
while(0)
#else
-#define rwsemdebug(FMT,...)
+//#define rwsemdebug(FMT,...)
#endif
/* old gcc */
#if RWSEM_DEBUG
-//#define rwsemdebug(FMT, ARGS...) do { if (sem->debug) printk(FMT,##ARGS); }
while(0)
+#define rwsemdebug(FMT, ARGS...) do { if (sem->debug) printk(FMT,##ARGS); }
while(0)
#else
-//#define rwsemdebug(FMT, ARGS...)
+#define rwsemdebug(FMT, ARGS...)
#endif
#ifdef CONFIG_X86_XADD
next reply other threads:[~2001-04-12 19:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-04-12 19:03 Wayne.Brown [this message]
2001-04-12 19:31 ` badly punctuated parameter list in `#define' (2.4.3-ac5 and 2.4.4 -pre2) Christoph Hellwig
2001-04-13 10:39 ` Jamie Lokier
2001-04-13 12:52 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86256A2C.0068BA0C.00@smtpnotes.altec.com \
--to=wayne.brown@altec.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.