From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Roman Stratiienko <r.stratiienko@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-sunxi@lists.linux.dev
Subject: Re: Re: Re: DE2.0 YV12 playback issues after ea067aee45a8
Date: Tue, 31 Aug 2021 20:49:30 +0200 [thread overview]
Message-ID: <8627733.mJVyAx2qjc@kista> (raw)
In-Reply-To: <CAGphcdnAtpFaAtp_QSKhNfQ4HkiL6dwYfP_pfMgNKwNGdyW-sw@mail.gmail.com>
Dne torek, 31. avgust 2021 ob 19:18:42 CEST je Roman Stratiienko napisal(a):
> Hi Jernej,
>
> вт, 31 авг. 2021 г. в 19:52, Jernej Škrabec <jernej.skrabec@gmail.com>:
> >
> > Hi!
> >
> > Dne petek, 27. avgust 2021 ob 15:16:03 CEST je Roman Stratiienko
napisal(a):
> > > +CC: jernej.skrabec@gmail.com
> > >
> > > пт, 27 авг. 2021 г. в 16:12, Roman Stratiienko
<r.stratiienko@gmail.com>:
> > > >
> > > > Hello Jernej,
> > > >
> > > > During local testing I faced an issue where YV12 buffers are displayed
> > > > all in blue.
> > > >
> > > > Issue can be fixed by reverting:
> > > > ea067aee45a8 ("drm/sun4i: de2/de3: Remove redundant CSC matrices")
> > > >
> > > > Could you have a look please?
> >
> > I believe I found the issue. Can you try replacing this line:
> > https://elixir.bootlin.com/linux/latest/source/drivers/gpu/drm/sun4i/
> > sun8i_csc.h#L20
> >
> > with:
> > #define SUN8I_CSC_COEFF(base, i) (base + 0x10 + 4 * (i))
> >
> > Note that "i" is in parenthesis.
>
> Thank you for your quick response.
> Yeah, that's it. Adding parenthesis solves the issue.
Thanks for reporting & testing!
Best regards,
Jernej
>
> >
> > Best regards,
> > Jernej
> >
> > > >
> > > > Best regards,
> > > > Roman Stratiienko
> > >
> >
> >
>
prev parent reply other threads:[~2021-08-31 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 13:12 DE2.0 YV12 playback issues after ea067aee45a8 Roman Stratiienko
2021-08-27 13:16 ` Roman Stratiienko
2021-08-31 16:38 ` Jernej Škrabec
2021-08-31 16:52 ` Jernej Škrabec
2021-08-31 17:18 ` Roman Stratiienko
2021-08-31 18:49 ` Jernej Škrabec [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8627733.mJVyAx2qjc@kista \
--to=jernej.skrabec@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=r.stratiienko@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.