From: Andre Przywara <andre.przywara@arm.com>
To: Michal Simek <michal.simek@xilinx.com>,
u-boot@lists.denx.de, git@xilinx.com
Cc: Fabio Estevam <festevam@denx.de>, Heiko Schocher <hs@denx.de>,
Jagan Teki <jagan@amarulasolutions.com>,
Kever Yang <kever.yang@rock-chips.com>,
Konstantin Porotchkin <kostap@marvell.com>,
Lokesh Vutla <lokeshvutla@ti.com>,
Peter Robinson <pbrobinson@gmail.com>,
Priyanka Jain <priyanka.jain@nxp.com>,
Tim Harvey <tharvey@gateworks.com>
Subject: Re: [PATCH 08/10] arm64: dts: Make sure that all DTBs are 64bit aligned for 64bit systems
Date: Thu, 19 Aug 2021 17:10:00 +0100 [thread overview]
Message-ID: <863295f0-3d4f-499a-78ae-57b5aaea36fe@arm.com> (raw)
In-Reply-To: <d7368b5886e8899e62bbd1ceab52df7181bb196f.1629371983.git.michal.simek@xilinx.com>
On 8/19/21 12:19 PM, Michal Simek wrote:
Hi Michal,
> DTBs for 64bit systems should be also 64bit aligned.
What does "align" mean here, exactly? This is about generating .dtb
*files*, right? dtc makes sure that the internal structures are properly
aligned, so what else should be aligned here?
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> arch/arm/dts/Makefile | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/dts/Makefile b/arch/arm/dts/Makefile
> index 537c96bf5b35..8d4fc333ea7a 100644
> --- a/arch/arm/dts/Makefile
> +++ b/arch/arm/dts/Makefile
> @@ -1,5 +1,9 @@
> # SPDX-License-Identifier: GPL-2.0+
>
> +ifdef CONFIG_PHYS_64BIT
> +DTC_FLAGS += -a 0x8
By looking into the dtc source this looks like to make sure the *size*
of the DTB is 8-byte aligned, is that the intention here, or even
useful? If it is, it should apply unconditionally, not only to 64-bit
systems.
Cheers,
Andre
> +endif
> +
> dtb-$(CONFIG_TARGET_SMARTWEB) += at91sam9260-smartweb.dtb
> dtb-$(CONFIG_TARGET_TAURUS) += at91sam9g20-taurus.dtb
> dtb-$(CONFIG_TARGET_CORVUS) += at91sam9g45-corvus.dtb
>
next prev parent reply other threads:[~2021-08-19 16:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 11:19 [PATCH 00/10] xilinx: Add support for DTB reselection Michal Simek
2021-08-19 11:19 ` [PATCH 01/10] xilinx: fru: Replace spaces with \0 in detected name Michal Simek
2021-08-19 11:19 ` [PATCH 02/10] xilinx: Use variable for passing board_name Michal Simek
2021-08-19 11:19 ` [PATCH 03/10] xilinx: common: Change board_info[] handling Michal Simek
2021-08-19 11:19 ` [PATCH 04/10] xilinx: common: Free allocated structure Michal Simek
2021-08-19 11:19 ` [PATCH 05/10] xilinx: Add support for generic board detection Michal Simek
2021-08-19 11:19 ` [PATCH 06/10] xilinx: zynqmp: Check that DT is 64bit aligned Michal Simek
2021-08-19 11:19 ` [PATCH 07/10] Makefile: Align fit-dtb.blob and u-boot.itb by 64bits for 64bit systems Michal Simek
2021-08-19 15:56 ` Andre Przywara
2021-08-19 16:01 ` Michal Simek
2021-08-19 16:18 ` Tom Rini
2021-08-19 16:31 ` Michal Simek
2021-08-19 16:44 ` Tom Rini
2021-08-19 11:19 ` [PATCH 08/10] arm64: dts: Make sure that all DTBs are 64bit aligned " Michal Simek
2021-08-19 16:10 ` Andre Przywara [this message]
2021-08-19 16:34 ` Michal Simek
2021-08-19 11:19 ` [PATCH 09/10] xilinx: zynqmp: Generate different u-boot.itb for MULTI_DTB_FIT Michal Simek
2021-08-19 11:19 ` [PATCH 10/10] xilinx: common: Enabling generic function for DT reselection Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863295f0-3d4f-499a-78ae-57b5aaea36fe@arm.com \
--to=andre.przywara@arm.com \
--cc=festevam@denx.de \
--cc=git@xilinx.com \
--cc=hs@denx.de \
--cc=jagan@amarulasolutions.com \
--cc=kever.yang@rock-chips.com \
--cc=kostap@marvell.com \
--cc=lokeshvutla@ti.com \
--cc=michal.simek@xilinx.com \
--cc=pbrobinson@gmail.com \
--cc=priyanka.jain@nxp.com \
--cc=tharvey@gateworks.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.