From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 56BBD3E1D13 for ; Thu, 21 May 2026 14:44:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779374694; cv=none; b=GB3/Gs1ODw3fL8kSrVJzw1i1tGOq61+F+JFNid8Zm8Y5k/KRYy7buSdHNxZvpjsRnDpqIrIyo9kcImslDnMksXuAv4cjbnnE1Lv2kRbZK/BSPlN5wpKeKwJVwzNvzJrHp+vynixKV5entGhy6yznJZjKobXOQuP4GCRB8YHICKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779374694; c=relaxed/simple; bh=Z6l64GGB3YlOyDzsBX0GyB0TR9WU7aDlkgSLW0OlHN8=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=s1XzUHSA6GCiRccgTJKKFQed7ybqeCyc4xDASoZf3sxOXSyfTntcijWOr7JdKhMscYpv2OzeofqDqT0jpuOo0Q2JhKlmEXGHGCaMi64CadfxHkw4fY4AawGletLsqec35BnCoCcnoAchlZJjH539/L1kI/VPvs1xHRLf1zE7Z70= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=LeYqpfIk; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="LeYqpfIk" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F14CA1F000E9; Thu, 21 May 2026 14:44:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1779374693; bh=TztbCbf7kGJEcrY5kULQQ3HNm/+LZONJ6KsIlNbIe1U=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=LeYqpfIkHe1l7SyYHvWCBRmNcg8EHauKEMMxanTCfZywLsRKAH5Tkgy/HLcAfha8n 8xkPTRLUcKvCTsLu76E5/HnzYE9MPQ6gOzo1Eh4CxFnurOYQuf0+Bbm9u/lmMraVKa hG1PzxVSvYpJRw7Q7pmtMxJvebtEw+eYa437bjg2ifwHDZwdV++j7PGzNfBF0VMkaX 39UzAkJZE+IEXIOFQJbqiZwREEZC+c4K4jSJwkdw09onNH6XgLnNdrIm/XMU2c97ou oUARZeCclcZEM4bHunQHQs+yYgdWP/jh3vrPy6z4ft7MZM7VYr2BHT57lq/lYtyCwp LzGTX8r/sqrWA== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98.2) (envelope-from ) id 1wQ4dn-00000004sX7-0UZw; Thu, 21 May 2026 14:44:51 +0000 Date: Thu, 21 May 2026 15:44:50 +0100 Message-ID: <8633zkx1nh.wl-maz@kernel.org> From: Marc Zyngier To: Vincent Donnefort Cc: oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kernel-team@android.com, qperret@google.com, tabba@google.com Subject: Re: [PATCH v3 0/3] Fix __pkvm_init_vm error path In-Reply-To: <20260521143318.1002172-1-vdonnefort@google.com> References: <20260521143318.1002172-1-vdonnefort@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/30.1 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: vdonnefort@google.com, oliver.upton@linux.dev, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, kernel-team@android.com, qperret@google.com, tabba@google.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 21 May 2026 15:33:15 +0100, Vincent Donnefort wrote: > > Sashiko reported a potential refcount leak in the unlikely case where > insert_vm_table_entry fails. > > While at it, I have added a fail-safe to __pkvm_hyp_donate_host to ensure this > function doesn't allow leaking refcounted pages. > > Changes since v3: > > * Enforce order-0 for external pages, making the vmemmap ->order field > completely private to hyp_pool. You send 3 versions of a single series in a matter of hours. How about taking a step back and working out the problems before posting? Please? It's not like my inbox is not overflowing already... M. -- Without deviation from the norm, progress is not possible.