From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 878D11C6F55 for ; Sun, 1 Dec 2024 13:00:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733058000; cv=none; b=pTOJL27qZBU0vsSeCUMS7eC2fjqQIRSq5aUo3ickGyDCy/uL1hzwIAexPGpC0JktFCk9tEKPIGzXZYf2yPA5XEkcPjEF/mgxcPBra22VZmrPtSZRGroEOm9sZwbK8pE4ZeslCiwUB2ewVtMAcG6saoRHdulUFlMA5mfXUsENxmY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733058000; c=relaxed/simple; bh=rJ2QT5zdZCcicZCA5CYn52IYa+shkRrR7BWOCgTczTY=; h=Date:Message-ID:From:To:Cc:Subject:In-Reply-To:References: MIME-Version:Content-Type; b=ua3p6CrZIBRvBKKmaz+mqTWZNc9OuRTZz0axVA87GUZ4vOxqpoUYc+kEsfIPz8Fyt17WjmpeGps7YaxSKR3F//N64045dLY9FNYXduB7bQfPulQFt0agTMwZjuurrdZZHIiyrhwhYpFaLELhB/Bm8hjcWZNjqxkRe1KpJOZgmVk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=nFJqh0oH; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="nFJqh0oH" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65B32C4CED2; Sun, 1 Dec 2024 13:00:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733058000; bh=rJ2QT5zdZCcicZCA5CYn52IYa+shkRrR7BWOCgTczTY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=nFJqh0oHiEMQheCx5FclnuhzgfjMYszMeaB2SPW7LQzflxQl7WLGT2nXSeTAhGtXx BQxKLw4ySy2bAlGUz+oXSmSZu3BMBUaIAGmAKlDJZWuGfj9hejU3oyPzymVSgKnajb 41p2ChcNgp7xZkxdXn8izhOhL7a7im1YTz89EZugRwARud9m01bekz4eZ1bsyflIqh OPUGQ+LIoyFxXiC19w8bqb3mnKLyM9xzThwI/PZx6mo2AyW6bFFSABlOPJwvAvM+HW GDfpB2tjT8lANxpxpcej4hOSLvTW84yD1iMJkA+lD4HTWW9z789QjmpvUkTreFgXyQ sICfzXVO8k09A== Received: from sofa.misterjones.org ([185.219.108.64] helo=goblin-girl.misterjones.org) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tHjYM-00H5dg-7Y; Sun, 01 Dec 2024 12:59:58 +0000 Date: Sun, 01 Dec 2024 12:59:57 +0000 Message-ID: <8634j7v9rm.wl-maz@kernel.org> From: Marc Zyngier To: Fuad Tabba Cc: kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, james.clark@linaro.org, will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, broonie@kernel.org, qperret@google.com, kristina.martsenko@arm.com Subject: Re: [PATCH v3 15/15] KVM: arm64: Renumber remaining vcpu guest configuration flags In-Reply-To: <20241128123515.1709777-16-tabba@google.com> References: <20241128123515.1709777-1-tabba@google.com> <20241128123515.1709777-16-tabba@google.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL-LB/10.8 EasyPG/1.0.0 Emacs/29.4 (aarch64-unknown-linux-gnu) MULE/6.0 (HANACHIRUSATO) Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: tabba@google.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, oliver.upton@linux.dev, james.clark@linaro.org, will@kernel.org, joey.gouly@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, catalin.marinas@arm.com, broonie@kernel.org, qperret@google.com, kristina.martsenko@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false On Thu, 28 Nov 2024 12:35:15 +0000, Fuad Tabba wrote: > > With the vcpu's SVE and PtrAuth configuration flags removed, > there are gaps in the numbering of the cflag bits. Renumber > VCPU_INITIALIZED to bit 0 to remove the gaps. > > No functional change intended. > > Signed-off-by: Fuad Tabba > --- > arch/arm64/include/asm/kvm_host.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > index c5c80c789ad0..2e4afec09728 100644 > --- a/arch/arm64/include/asm/kvm_host.h > +++ b/arch/arm64/include/asm/kvm_host.h > @@ -864,10 +864,10 @@ struct kvm_vcpu_arch { > #define vcpu_set_flag(v, ...) __vcpu_set_flag((v), __VA_ARGS__) > #define vcpu_clear_flag(v, ...) __vcpu_clear_flag((v), __VA_ARGS__) > > +/* KVM_ARM_VCPU_INIT completed */ > +#define VCPU_INITIALIZED __vcpu_single_flag(cflags, BIT(0)) > /* SVE config completed */ > #define VCPU_SVE_FINALIZED __vcpu_single_flag(cflags, BIT(1)) > -/* KVM_ARM_VCPU_INIT completed */ > -#define VCPU_INITIALIZED __vcpu_single_flag(cflags, BIT(3)) > > /* Exception pending */ > #define PENDING_EXCEPTION __vcpu_single_flag(iflags, BIT(0)) Please fold this with the relevant patches, even if that makes two consecutive renumbering patches. Thanks, M. -- Without deviation from the norm, progress is not possible.