From: Marc Zyngier <maz@kernel.org>
To: "Arnd Bergmann" <arnd@arndb.de>
Cc: "Randy Dunlap" <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Rob Herring" <robh@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Peter Rosin" <peda@axentia.se>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it
Date: Wed, 14 Feb 2024 16:35:17 +0000 [thread overview]
Message-ID: <8634tv57i2.wl-maz@kernel.org> (raw)
In-Reply-To: <c6e55baf-4f0c-4342-971a-713ed55f5a51@app.fastmail.com>
On Wed, 14 Feb 2024 16:06:06 +0000,
"Arnd Bergmann" <arnd@arndb.de> wrote:
>
> On Wed, Feb 14, 2024, at 10:52, Marc Zyngier wrote:
> > On Tue, 13 Feb 2024 22:56:19 +0000, Randy Dunlap <rdunlap@infradead.org> wrote:
> >>
> >> diff -- a/drivers/of/Kconfig b/drivers/of/Kconfig
> >> --- a/drivers/of/Kconfig
> >> +++ b/drivers/of/Kconfig
> >> @@ -80,7 +80,8 @@ config OF_ADDRESS
> >>
> >> config OF_IRQ
> >> def_bool y
> >> - depends on !SPARC && IRQ_DOMAIN
> >> + depends on !SPARC
> >> + select IRQ_DOMAIN
> >
> >
> > This seems to be moving is the right direction.
>
> Can we move the 'select IRQ_DOMAIN' under CONFIG_IRQCHIP
> then and remove the individual selects from the irqchip
> drivers? It looks like CONFIG_OF (other than sparc) now
> unconditionally enables OF_IRQ and IRQCHIP anyway.
As long as it also works ACPI, it should be OK.
M.
--
Without deviation from the norm, progress is not possible.
next prev parent reply other threads:[~2024-02-14 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 22:56 [PATCH v2] of: OF_IRQ: select IRQ_DOMAIN instead of depending on it Randy Dunlap
2024-02-14 9:52 ` Marc Zyngier
2024-02-14 16:06 ` Arnd Bergmann
2024-02-14 16:35 ` Marc Zyngier [this message]
2024-02-14 17:22 ` Arnd Bergmann
2024-02-15 15:08 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8634tv57i2.wl-maz@kernel.org \
--to=maz@kernel.org \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=peda@axentia.se \
--cc=rdunlap@infradead.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.