From: Eugene Zaikonnikov <ez@norphonic.com>
To: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
"development\@norphonic.com" <development@norphonic.com>,
"linux-iio\@vger.kernel.org" <linux-iio@vger.kernel.org>
Subject: Re: [PATCH v8 1/2] Driver for TI HDC20x0 humidity and temperature sensors
Date: Thu, 11 Jun 2020 15:02:05 +0200 [thread overview]
Message-ID: <863671oiwi.fsf@norphonic.com> (raw)
In-Reply-To: <20200519191103.00004489@Huawei.com>
Jonathan Cameron <Jonathan.Cameron@Huawei.com> writes:
> On Mon, 18 May 2020 19:15:27 +0000
> Eugene Zalkonnikov <ez@norphonic.com> wrote:
>
> Hi Eugene
>
>> HDC2010/2080 driver and sysfs documentation for its heater element.
>>
>
> Would be nice to have a little more info on the device for anyone reading
> the log after we commit this.
>
Ok I'll expand the description.
> There is a potential double free in the remove path due to mix of
> devm_iio_device_register and iio_device_unregister.
>
Right, overlooked this. Will changine the unregister to the managed
version suffice?
> Also, the error paths in probe don't undo the various bits of setup
> that it feels like they should. This might not matter in reality
> but the code will be more obviously correct if it is fine to reset
> the amm bit.
>
I'll add that.
--
Regards,
Eugene Zaikonnikov
Norphonic AS
Tel: +47 98 23 97 73
next prev parent reply other threads:[~2020-06-11 13:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 19:15 [PATCH v8 1/2] Driver for TI HDC20x0 humidity and temperature sensors Eugene Zalkonnikov
2020-05-18 19:22 ` [PATCH v8 2/2] Device tree bindings " Eugene Zalkonnikov
2020-05-26 18:35 ` Rob Herring
2020-07-08 8:57 ` Eugene Zaikonnikov
2020-05-19 18:11 ` [PATCH v8 1/2] Driver " Jonathan Cameron
2020-06-11 13:02 ` Eugene Zaikonnikov [this message]
2020-06-14 11:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=863671oiwi.fsf@norphonic.com \
--to=ez@norphonic.com \
--cc=Jonathan.Cameron@Huawei.com \
--cc=development@norphonic.com \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.