From: Qingfang Deng <qingfang.deng@linux.dev>
To: "Luiz Angelo Daros de Luca" <luizluca@gmail.com>,
"Linus Walleij" <linusw@kernel.org>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: realtek: rtl8365mb: use devm_mutex_init
Date: Sun, 19 Jul 2026 10:41:04 +0800 [thread overview]
Message-ID: <8638d68c-4bb8-476f-97d3-98f433949ab7@linux.dev> (raw)
In-Reply-To: <20260718-realtek_mutext-v1-1-1cd7beb20ae6@gmail.com>
Hi Luiz,
On 7/18/2026 1:59 PM, Luiz Angelo Daros de Luca wrote:
> mutex_destroy() is needed while debugging mutex. Instead of calling it
> directly on driver .remove(), just use devm.
>
> Signed-off-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
> ---
> drivers/net/dsa/realtek/rtl8365mb_main.c | 15 ++++++++++++---
> drivers/net/dsa/realtek/rtl83xx.c | 14 +++++++++++---
> 2 files changed, 23 insertions(+), 6 deletions(-)
As you're fixing a missing teardown, and the two files were introduced
at different times, you should split your patch into two (one for each
file), re-target your series to the "net" tree, and add a Fixes tag
respectively.
Best regards,
Qingfang
prev parent reply other threads:[~2026-07-19 2:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 5:59 [PATCH net-next] net: dsa: realtek: rtl8365mb: use devm_mutex_init Luiz Angelo Daros de Luca
2026-07-19 2:41 ` Qingfang Deng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8638d68c-4bb8-476f-97d3-98f433949ab7@linux.dev \
--to=qingfang.deng@linux.dev \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.