All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arsen Arsenović via Grub-devel" <grub-devel@gnu.org>
To: Leo Sandoval <lsandova@redhat.com>
Cc: "Arsen Arsenović" <arsen@aarsen.me>, grub-devel@gnu.org
Subject: Re: [PATCH 14/20] 10_linux.in 20_linux_xen.in: Don't say "GNU/Linux" in generated menus.
Date: Tue, 01 Oct 2024 00:07:12 +0200	[thread overview]
Message-ID: <864j5wyewf.fsf@aarsen.me> (raw)
In-Reply-To: <20240930174349.1295414-15-lsandova@redhat.com> (Leo Sandoval's message of "Mon, 30 Sep 2024 11:43:43 -0600")


[-- Attachment #1.1: Type: text/plain, Size: 1614 bytes --]

Leo Sandoval <lsandova@redhat.com> writes:

> From: Peter Jones <pjones@redhat.com>
>
> [rharwood: say it even less]
> ---
>  grub-core/normal/main.c         | 2 +-
>  tests/util/grub-shell-tester.in | 2 +-
>  tests/util/grub-shell.in        | 2 +-
>  util/grub.d/10_linux.in         | 4 ++--
>  util/grub.d/20_linux_xen.in     | 4 ++--
>  5 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/grub-core/normal/main.c b/grub-core/normal/main.c
> index 1317279c0..568c2adfa 100644
> --- a/grub-core/normal/main.c
> +++ b/grub-core/normal/main.c
> @@ -218,7 +218,7 @@ grub_normal_init_page (struct grub_term_output *term,
>  
>    grub_term_cls (term);
>  
> -  msg_formatted = grub_xasprintf (_("GNU GRUB  version %s"), PACKAGE_VERSION);
> +  msg_formatted = grub_xasprintf (_("GRUB version %s"), PACKAGE_VERSION);
>    if (!msg_formatted)
>      return;
>  
> diff --git a/tests/util/grub-shell-tester.in b/tests/util/grub-shell-tester.in
> index 8a87109b1..9a4319d4f 100644
> --- a/tests/util/grub-shell-tester.in
> +++ b/tests/util/grub-shell-tester.in
> @@ -56,7 +56,7 @@ for option in "$@"; do
>  	usage
>  	exit 0 ;;
>      -v | --version)
> -	echo "$0 (GNU GRUB ${PACKAGE_VERSION})"
> +	echo "$0 (GRUB ${PACKAGE_VERSION})"

This and related changes seem bizarre?  I can understand changing
GNU/Linux -> Linux on some systems (based on uname -o for instance, or
just by using PRETTY_NAME from /etc/os-release or ...), but not
blanket-removing 'GNU' from the sources, even when it pertains to GRUB
rather than whatever distribution.
-- 
Arsen Arsenović

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 381 bytes --]

[-- Attachment #2: Type: text/plain, Size: 141 bytes --]

_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

  reply	other threads:[~2024-09-30 22:08 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 17:43 [PATCH 00/20] First Distro-agnostic series taken from Fedora Rawhide Leo Sandoval
2024-09-30 17:43 ` [PATCH 01/20] ieee1275/openfw: IBM client architecture (CAS) reboot support Leo Sandoval
2024-09-30 17:43 ` [PATCH 02/20] term/terminfo: for ppc, reset console display attr when clear screen Leo Sandoval
2024-09-30 17:43 ` [PATCH 03/20] ieee1275: Disable GRUB video support for IBM power machines Leo Sandoval
2024-09-30 19:07   ` Vladimir 'phcoder' Serbinenko
2024-10-02 17:51     ` Leo Sandoval
2024-09-30 17:43 ` [PATCH 04/20] configure.ac: Move bash completion script Leo Sandoval
2024-09-30 17:43 ` [PATCH 05/20] normal/menu: Allow "fallback" to include entries by title, not just number Leo Sandoval
2024-09-30 19:02   ` Vladimir 'phcoder' Serbinenko
2024-10-02 17:40     ` Leo Sandoval
2024-09-30 17:43 ` [PATCH 06/20] misc: Make "exit" take a return code Leo Sandoval
2024-09-30 17:43 ` [PATCH 07/20] efi/init: Make efi machines load an env block from a variable Leo Sandoval
2024-09-30 17:43 ` [PATCH 08/20] 20_ppc_terminfo.in: Migrate PPC from Yaboot to Grub2 Leo Sandoval
2024-09-30 18:56   ` Vladimir 'phcoder' Serbinenko
2024-10-02 17:11     ` Leo Sandoval
2024-10-02 22:27       ` Vladimir 'phcoder' Serbinenko
2024-09-30 17:43 ` [PATCH 09/20] normal: Add fw_path variable (revised) Leo Sandoval
2024-09-30 17:43 ` [PATCH 10/20] commands: Pass "\x[[:hex:]][[:hex:]]" straight through unmolested Leo Sandoval
2024-09-30 17:43 ` [PATCH 11/20] blscfg: add blscfg module to parse Boot Loader Specification snippets Leo Sandoval
2024-09-30 19:08   ` Vladimir 'phcoder' Serbinenko
2024-10-02 18:15     ` Leo Sandoval
2024-09-30 17:43 ` [PATCH 12/20] 10_linux.in: Add devicetree loading Leo Sandoval
2024-09-30 17:43 ` [PATCH 13/20] 00_header.in: Enable pager by default. (#985860) Leo Sandoval
2024-09-30 17:43 ` [PATCH 14/20] 10_linux.in 20_linux_xen.in: Don't say "GNU/Linux" in generated menus Leo Sandoval
2024-09-30 22:07   ` Arsen Arsenović via Grub-devel [this message]
2024-09-30 23:24   ` Vladimir 'phcoder' Serbinenko
2024-10-01 10:00     ` Mate Kukri
2024-09-30 17:43 ` [PATCH 15/20] Makefile.common: Add .eh_frame to list of relocations stripped Leo Sandoval
2024-09-30 17:43 ` [PATCH 16/20] 10_linux.in: Don't require a password to boot entries generated by grub-mkconfig Leo Sandoval
2024-09-30 17:43 ` [PATCH 17/20] normal/main: fw_path prefix when fallback searching for grub config Leo Sandoval
2024-09-30 17:43 ` [PATCH 18/20] normal/main: Try mac/guid/etc before grub.cfg on tftp config files Leo Sandoval
2024-09-30 17:43 ` [PATCH 19/20] 10_linux.in: Generate OS and CLASS in 10_linux from /etc/os-release Leo Sandoval
2024-09-30 17:43 ` [PATCH 20/20] normal/main: Try $prefix if $fw_path doesn't work Leo Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=864j5wyewf.fsf@aarsen.me \
    --to=grub-devel@gnu.org \
    --cc=arsen@aarsen.me \
    --cc=lsandova@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.